Bug 200704 – Web Inspector: Uncaught Exception: Content request failed.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Hit this on a ToT debug build when clicking websocket.js in the Resources tab.

Content request failed. (at Resource.js:​835:​40)​
    requestContentFromBackend @ Resource.js:​835:​40
    requestContent @ SourceCode.js:​140:​100
    _tryEnableCustomResponseContentView @ ResourceClusterContentView.js:​367:​38
    ResourceClusterContentView @ ResourceClusterContentView.js:​71:​49
    createFromRepresentedObject @ ContentView.js:​52:​53
    contentViewForRepresentedObject @ ContentView.js:​211:​72
    showContentViewForRepresentedObject @ ContentBrowser.js:​151:​63
    showRepresentedObject @ ContentBrowserTabContentView.js:​230:​64
    ?​ @ Main.js:​1331:​41
    _treeSelectionDidChange @ ResourceSidebarPanel.js:​487:​37
    dispatch @ Object.js:​165:​30
    dispatchEventToListeners @ Object.js:​172:​17
    _dispatchSelectionDidChangeEvent @ TreeOutline.js:​1136:​38
    selectionControllerSelectionDidChange @ TreeOutline.js:​813:​46
    _updateSelectedItems @ SelectionController.js:​392:​65
    selectItem @ SelectionController.js:​97:​34
    handleItemMouseDown @ SelectionController.js:​258:​28
    _handleMouseDown @ TreeOutline.js:​1122:​54
    _handleMouseDown @ [native code]

[Devin Rousso]

<rdar://problem/54279372>

[Devin Rousso]

Created attachment 376247 [details]
Patch

[Greg Marriott]

Comment on attachment 376247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review

> Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:92
> +        console.assert(false, "A WebSocket itself has no content, and should never be requested of as such.");

"A WebSocket's content was requested. WebSockets do not have content so the request is nonsensical."

[Blaze Burg]

Comment on attachment 376247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:92
>> +        console.assert(false, "A WebSocket itself has no content, and should never be requested of as such.");
> 
> "A WebSocket's content was requested. WebSockets do not have content so the request is nonsensical."

+1 to Greg's wording :)

> Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:369
> +            return;

It would be nice to hook the websocket "response" view into the custom view machinery, but not necessary to fix this bug.

[Devin Rousso]

Comment on attachment 376247 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review

>> Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:369
>> +            return;
> 
> It would be nice to hook the websocket "response" view into the custom view machinery, but not necessary to fix this bug.

It's already used by the "regular" response view above in `_contentViewForResourceType`.

I see a difference between the "regular" response view and the "custom" response view.  The "regular" view is something that's immediately deducible just from the resource type (e.g. an image should be displayed differently than text), whereas the "custom" view is for special situations where some aspect of the resource warrants additional UI (e.g. text is actually JSON content).  We already do something like this for SVG images (I would argue that that's more of a special case though because I'd consider an SVG image to be _both_ textual and graphical, so even though showing both is "custom", I don't think it would fit here).

In the case of WebSocket, I could see us creating (either here or making `WI.WebSocketContentView` into a cluster like SVG images) a JSON view where all frames are automatically shown as JSON views instead, but I'm not sure how common JSON is for frames (e.g. socket.io has it's own format).

[Devin Rousso]

Created attachment 376267 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 376247 [details]
Patch

Nice!

[WebKit Commit Bot]

Comment on attachment 376267 [details]
Patch

Clearing flags on attachment: 376267

Committed r248720: <https://trac.webkit.org/changeset/248720>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.