Bug 200700 - [WHLSL] Make length, clamp, operator+, operator-, operator*, operator/, operator[], operator[]=, operator.xy, operator.xy=, native
Summary: [WHLSL] Make length, clamp, operator+, operator-, operator*, operator/, opera...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 200699
  Show dependency tree / graph
 
Reported: 2019-08-13 19:56 PDT by Saam Barati
Modified: 2019-08-15 13:14 PDT (History)
9 users (show)

See Also:

Attachments
WIP (144.30 KB, patch)
2019-08-13 19:58 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (62.04 KB, patch)
2019-08-13 20:12 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
WIP (100.72 KB, patch)
2019-08-13 20:29 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (118.35 KB, patch)
2019-08-14 18:45 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-08-13 19:56:20 PDT 
...
Comment 1 Saam Barati 2019-08-13 19:58:35 PDT 
Created attachment 376230 [details]
WIP

contains some other random stuff ATM
Comment 2 Saam Barati 2019-08-13 20:12:07 PDT 
Created attachment 376232 [details]
WIP
Comment 3 Saam Barati 2019-08-13 20:29:37 PDT 
Created attachment 376233 [details]
WIP

Need to implement and add tests for "scalar <op> matrix" and "scalar <op> vector" (hopefully just tests for the latter).
Comment 4 Saam Barati 2019-08-14 18:45:56 PDT 
Created attachment 376340 [details]
patch
Comment 5 Robin Morisset 2019-08-14 20:22:07 PDT 
Comment on attachment 376340 [details]
patch

I don't see where you define the new operator.xy.
Otherwise it looks reasonable.
It led me to discover that our semantic does not appear to match HLSL's one for scalar * vector operators. I will open a new bug about that.
Comment 6 Robin Morisset 2019-08-14 20:24:50 PDT 
Comment on attachment 376340 [details]
patch

r=me
Saam explained offline how we already had code that can support operator.xy
Comment 7 WebKit Commit Bot 2019-08-15 11:01:23 PDT 
Comment on attachment 376340 [details]
patch

Clearing flags on attachment: 376340

Committed r248730: <https://trac.webkit.org/changeset/248730>
Comment 8 WebKit Commit Bot 2019-08-15 11:01:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-08-15 11:02:20 PDT 
<rdar://problem/54353687>
Comment 10 Saam Barati 2019-08-15 13:14:06 PDT 
debug build fix in:
https://trac.webkit.org/changeset/248740/webkit