Bug 200696 - [WHLSL] Move Qualifiers and Semantic from VariableDeclaration to VariableDeclaration::RareData
Summary: [WHLSL] Move Qualifiers and Semantic from VariableDeclaration to VariableDecl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-13 17:33 PDT by Robin Morisset
Modified: 2019-08-13 18:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2019-08-13 17:35 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-08-13 17:33:50 PDT
It is super rare for variable declarations to have either a semantic or qualifiers.
Yet we take 24 bytes from each and every one of them to store these.
We can trivially hoist them into a separate structure, to save 16 bytes per variable declaration (from 56 to 40).
Comment 1 Robin Morisset 2019-08-13 17:35:49 PDT
Created attachment 376225 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-13 18:36:32 PDT
Comment on attachment 376225 [details]
Patch

Clearing flags on attachment: 376225

Committed r248656: <https://trac.webkit.org/changeset/248656>
Comment 3 WebKit Commit Bot 2019-08-13 18:36:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-08-13 18:37:18 PDT
<rdar://problem/54283914>