Bug 200663 - Fail decoding an invalid SessionID
Summary: Fail decoding an invalid SessionID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-13 02:03 PDT by youenn fablet
Modified: 2019-08-14 02:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.77 KB, patch)
2019-08-13 02:05 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-08-13 02:03:21 PDT
Fail decoding an invalid SessionID
Comment 1 youenn fablet 2019-08-13 02:05:01 PDT
Created attachment 376152 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-08-13 03:59:17 PDT
<rdar://problem/54251062>
Comment 3 youenn fablet 2019-08-13 04:00:07 PDT
I kept a release assert for now when encoding a bad sessionID.
Plan is to let it seat for a while and move it back to a regular ASSERT.
I can change it back to a regular ASSERT() if that is thought as too crash risky though.
Comment 4 Alex Christensen 2019-08-13 10:47:42 PDT
Comment on attachment 376152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review

> Source/WebCore/PAL/pal/SessionID.h:86
> +    // FIXME: Change to a regular ASSERT.
> +    RELEASE_ASSERT(isValid());

I think we should just leave it a RELEASE_ASSERT
Comment 5 Alex Christensen 2019-08-13 10:48:20 PDT
Comment on attachment 376152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review

> Source/WebCore/PAL/pal/SessionID.h:-107
> -    // FIXME: We should fail to decode an invalid sessionID.

I think we ought to return nullopt if isValid() is false.
Comment 6 youenn fablet 2019-08-14 01:59:14 PDT
Comment on attachment 376152 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376152&action=review

>> Source/WebCore/PAL/pal/SessionID.h:86
>> +    RELEASE_ASSERT(isValid());
> 
> I think we should just leave it a RELEASE_ASSERT

OK.

>> Source/WebCore/PAL/pal/SessionID.h:-107
>> -    // FIXME: We should fail to decode an invalid sessionID.
> 
> I think we ought to return nullopt if isValid() is false.

It is returning nullopt, see line above.
Comment 7 WebKit Commit Bot 2019-08-14 02:27:07 PDT
Comment on attachment 376152 [details]
Patch

Clearing flags on attachment: 376152

Committed r248663: <https://trac.webkit.org/changeset/248663>
Comment 8 WebKit Commit Bot 2019-08-14 02:27:09 PDT
All reviewed patches have been landed.  Closing bug.