Bug 200655 - Web Inspector: Remove bad semicolon in generation of ObjC methods
Summary: Web Inspector: Remove bad semicolon in generation of ObjC methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-12 20:39 PDT by Joseph Pecoraro
Modified: 2019-08-14 11:21 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.05 KB, patch)
2019-08-12 20:39 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-08-12 20:39:07 PDT 
Remove bad semicolon in generation of ObjC methods

Can trigger pedantic warnings.
Comment 1 Joseph Pecoraro 2019-08-12 20:39:57 PDT 
Created attachment 376132 [details]
[PATCH] Proposed Fix
Comment 2 EWS Watchlist 2019-08-12 20:42:25 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Devin Rousso 2019-08-12 21:09:06 PDT 
Comment on attachment 376132 [details]
[PATCH] Proposed Fix

r=me, nice catch!
Comment 4 EWS Watchlist 2019-08-12 23:30:45 PDT 
Comment on attachment 376132 [details]
[PATCH] Proposed Fix

Attachment 376132 [details] did not pass jsc-ews (mac):
Output: https://webkit-queues.webkit.org/results/12902099

New failing tests:
mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl
Comment 5 WebKit Commit Bot 2019-08-14 11:20:24 PDT 
Comment on attachment 376132 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 376132

Committed r248680: <https://trac.webkit.org/changeset/248680>
Comment 6 WebKit Commit Bot 2019-08-14 11:20:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-14 11:21:20 PDT 
<rdar://problem/54310565>