RESOLVED FIXED Bug 200655
Web Inspector: Remove bad semicolon in generation of ObjC methods 
https://bugs.webkit.org/show_bug.cgi?id=200655
Summary Web Inspector: Remove bad semicolon in generation of ObjC methods
Joseph Pecoraro
Reported 2019-08-12 20:39:07 PDT
Remove bad semicolon in generation of ObjC methods Can trigger pedantic warnings.
Attachments
[PATCH] Proposed Fix (6.05 KB, patch)
2019-08-12 20:39 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-08-12 20:39:57 PDT
Created attachment 376132 [details] [PATCH] Proposed Fix
EWS Watchlist
Comment 2 2019-08-12 20:42:25 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Devin Rousso
Comment 3 2019-08-12 21:09:06 PDT
Comment on attachment 376132 [details] [PATCH] Proposed Fix r=me, nice catch!
EWS Watchlist
Comment 4 2019-08-12 23:30:45 PDT
Comment on attachment 376132 [details] [PATCH] Proposed Fix Attachment 376132 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12902099 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-no-ftl
WebKit Commit Bot
Comment 5 2019-08-14 11:20:24 PDT
Comment on attachment 376132 [details] [PATCH] Proposed Fix Clearing flags on attachment: 376132 Committed r248680: <https://trac.webkit.org/changeset/248680>
WebKit Commit Bot
Comment 6 2019-08-14 11:20:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-14 11:21:20 PDT
<rdar://problem/54310565>
Note You need to log in before you can comment on or make changes to this bug.