Bug 200649 - Add a way to opt out of kern TCSM for layout tests
Summary: Add a way to opt out of kern TCSM for layout tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-12 17:02 PDT by Saam Barati
Modified: 2019-08-13 20:38 PDT (History)
16 users (show)

See Also:

Attachments
patch (2.04 KB, patch)
2019-08-12 19:06 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
set-environment-webkitpy (1.52 KB, patch)
2019-08-13 16:33 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2019-08-12 17:02:06 PDT 
...
Comment 1 Saam Barati 2019-08-12 17:02:38 PDT 
<rdar://problem/51304923>
Comment 2 Saam Barati 2019-08-12 19:06:13 PDT 
Created attachment 376127 [details]
patch
Comment 3 Alexey Proskuryakov 2019-08-12 20:26:43 PDT 
Comment on attachment 376127 [details]
patch

How does one pass an option of this kind to WebKitTestRunner’s WebContent process?
Comment 4 Saam Barati 2019-08-13 15:06:02 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 376127 [details]
> patch
> 
> How does one pass an option of this kind to WebKitTestRunner’s WebContent
> process?

Set the environment variable "JSC_useKernTCSM=false"
Comment 5 Jonathan Bedard 2019-08-13 16:33:37 PDT 
Created attachment 376223 [details]
set-environment-webkitpy

Should we be setting this webkitpy? Or in WebKitTestRunner/DumpRenderTree?
Comment 6 Alexey Proskuryakov 2019-08-13 17:10:05 PDT 
> Should we be setting this webkitpy? Or in WebKitTestRunner/DumpRenderTree?

I don't think that there is any practical difference. Theoretically, setting it in WebKitTestRunner/DumpRenderTree is slightly better because running them manually (without run-webkit-tests) will result in the same behavior as with run-webkit-tests.

In addition to layout tests, JSC tests probably need this too.

Also, we should probably use a separate bug for the adoption.
Comment 7 WebKit Commit Bot 2019-08-13 20:38:13 PDT 
Comment on attachment 376127 [details]
patch

Clearing flags on attachment: 376127

Committed r248661: <https://trac.webkit.org/changeset/248661>
Comment 8 WebKit Commit Bot 2019-08-13 20:38:15 PDT 
All reviewed patches have been landed.  Closing bug.