Bug 200633 – [GStreamer] Deal with slow buffer consumption in GStreamerMediaStreamSource

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Thibault Saunier]

[GStreamer] Deal with slow buffer consumption in GStreamerMediaStreamSource

[Thibault Saunier]

Created attachment 376077 [details]
Patch

[Philippe Normand]

Comment on attachment 376077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376077&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:553
>  static gboolean webkitMediaStreamSrcSetupAppSrc(WebKitMediaStreamSrc* self,
> -    MediaStreamTrackPrivate* track, GstElement** element,
> +    MediaStreamTrackPrivate* track, WebKitMediaStreamSrc::SourceData* data,
>      GstStaticPadTemplate* pad_template, bool onlyTrack)

Where's the call site for this? I don't see it updated in this patch?

[Thibault Saunier]

Comment on attachment 376077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376077&action=review

>> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:553
>>      GstStaticPadTemplate* pad_template, bool onlyTrack)
> 
> Where's the call site for this? I don't see it updated in this patch?

In `webkitMediaStreamSrcAddTrack` - no need to update it here as it does:

>        res = webkitMediaStreamSrcSetupAppSrc(self, track, &self->audioSrc, &audioSrcTemplate, onlyTrack);

and `self->audioSrc` has been changed to `WebKitMediaStreamSrc::SourceData`.

[WebKit Commit Bot]

Comment on attachment 376077 [details]
Patch

Clearing flags on attachment: 376077

Committed r248721: <https://trac.webkit.org/changeset/248721>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54351290>