Bug 200622 - [MSE][GStreamer] Don't use vorbisparse
Summary: [MSE][GStreamer] Don't use vorbisparse
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-11 08:01 PDT by Alicia Boya García
Modified: 2019-08-11 09:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.29 KB, patch)
2019-08-11 08:03 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2019-08-11 08:01:58 PDT
This patch has been splitted from the original WebKitMediaSrc rework
patch (https://bugs.webkit.org/show_bug.cgi?id=199719).

Unlike other parsers, vorbisparse has latency (in the sense that when
it gets a chain call with a series of complete frames, it may not emit
the parsed frames until another chain in the future), which makes it
inappropriate for AppendPipeline, as there is no good way I know to
flush it.

But actually vorbisparse is not known to be necessary and it was only
introduced for consistency with other formats. Parsers are used in
AppendPipeline to reconstruct information that is lost due to poor
muxes. There have been no reported cases of this being a problem with
Vorbis in WebM, so I'm just removing the parser.

Fixes imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-a-bitrate.html
Comment 1 Alicia Boya García 2019-08-11 08:03:06 PDT
Created attachment 376042 [details]
Patch
Comment 2 WebKit Commit Bot 2019-08-11 09:21:31 PDT
Comment on attachment 376042 [details]
Patch

Clearing flags on attachment: 376042

Committed r248521: <https://trac.webkit.org/changeset/248521>
Comment 3 WebKit Commit Bot 2019-08-11 09:21:33 PDT
All reviewed patches have been landed.  Closing bug.