200620 – [WTF] Add makeUnique<T>, which ensures T is fast-allocated

RESOLVED FIXED 200620

[WTF] Add makeUnique<T>, which ensures T is fast-allocated

https://bugs.webkit.org/show_bug.cgi?id=200620

Summary [WTF] Add makeUnique<T>, which ensures T is fast-allocated

Yusuke Suzuki

Reported 2019-08-10 19:42:13 PDT

...

Attachments
Patch (1.64 MB, patch) 2019-08-13 00:55 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.64 MB, patch) 2019-08-13 01:15 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.65 MB, patch) 2019-08-13 01:32 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.65 MB, patch) 2019-08-13 01:57 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.65 MB, patch) 2019-08-13 02:19 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.65 MB, patch) 2019-08-13 02:43 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.68 MB, patch) 2019-08-13 05:08 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.68 MB, patch) 2019-08-13 05:15 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.68 MB, patch) 2019-08-13 12:12 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.70 MB, patch) 2019-08-14 15:37 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.71 MB, patch) 2019-08-14 17:48 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.71 MB, patch) 2019-08-14 18:21 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.71 MB, patch) 2019-08-14 21:35 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.71 MB, patch) 2019-08-14 23:26 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.71 MB, patch) 2019-08-14 23:31 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.72 MB, patch) 2019-08-15 00:03 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.72 MB, patch) 2019-08-15 01:06 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.72 MB, patch) 2019-08-15 13:46 PDT, Yusuke Suzuki	ggaren: review+	Details Formatted Diff Diff
A: Annotation Patch (308.45 KB, patch) 2019-08-15 20:31 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
B: makeUnique / makeUniqueWithoutFastMallocCheck (1.48 MB, patch) 2019-08-16 02:05 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
B: makeUnique / makeUniqueWithoutFastMallocCheck (1.48 MB, patch) 2019-08-16 02:10 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
B: makeUnique / makeUniqueWithoutFastMallocCheck (1.49 MB, patch) 2019-08-18 23:44 PDT, Yusuke Suzuki	ews-watchlist: commit-queue-	Details Formatted Diff Diff
C: makeUnique should perform static-assert (4.96 KB, patch) 2019-08-19 00:16 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
C: makeUnique should perform static-assert (6.47 KB, patch) 2019-08-19 00:54 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Show Obsolete (20) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2019-08-11 03:06:59 PDT

I tried and it finds many classes / structs that are not allocated from FastMalloc. It is worth doing.

Yusuke Suzuki

Comment 2 2019-08-13 00:55:09 PDT

Created attachment 376144 [details] Patch

EWS Watchlist

Comment 3 2019-08-13 01:01:28 PDT

Attachment 376144 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1242 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 4 2019-08-13 01:15:10 PDT

Created attachment 376145 [details] Patch

EWS Watchlist

Comment 5 2019-08-13 01:22:34 PDT

Attachment 376145 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1242 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 6 2019-08-13 01:32:36 PDT

Created attachment 376147 [details] Patch

EWS Watchlist

Comment 7 2019-08-13 01:39:04 PDT

Attachment 376147 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1244 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 8 2019-08-13 01:57:18 PDT

Created attachment 376151 [details] Patch

Yusuke Suzuki

Comment 9 2019-08-13 02:19:57 PDT

Created attachment 376153 [details] Patch

EWS Watchlist

Comment 10 2019-08-13 02:26:03 PDT

Attachment 376153 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1246 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 11 2019-08-13 02:43:59 PDT

Created attachment 376154 [details] Patch

EWS Watchlist

Comment 12 2019-08-13 02:50:16 PDT

Attachment 376154 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1251 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 13 2019-08-13 05:08:25 PDT

Created attachment 376156 [details] Patch

Yusuke Suzuki

Comment 14 2019-08-13 05:15:57 PDT

Created attachment 376157 [details] Patch

EWS Watchlist

Comment 15 2019-08-13 05:21:23 PDT

Attachment 376157 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:426: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1286 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 16 2019-08-13 12:12:00 PDT

Created attachment 376192 [details] Patch

EWS Watchlist

Comment 17 2019-08-13 12:18:01 PDT

Attachment 376192 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1288 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 18 2019-08-14 15:37:27 PDT

Created attachment 376323 [details] Patch

EWS Watchlist

Comment 19 2019-08-14 15:45:02 PDT

Attachment 376323 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1309 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 20 2019-08-14 17:48:27 PDT

Created attachment 376337 [details] Patch

Yusuke Suzuki

Comment 21 2019-08-14 18:21:18 PDT

Created attachment 376339 [details] Patch

EWS Watchlist

Comment 22 2019-08-14 18:27:27 PDT

Attachment 376339 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1312 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 23 2019-08-14 21:35:07 PDT

Created attachment 376351 [details] Patch

EWS Watchlist

Comment 24 2019-08-14 21:40:58 PDT

Attachment 376351 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1315 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 25 2019-08-14 23:26:39 PDT

Created attachment 376360 [details] Patch

Yusuke Suzuki

Comment 26 2019-08-14 23:31:39 PDT

Created attachment 376362 [details] Patch

EWS Watchlist

Comment 27 2019-08-14 23:41:01 PDT

Attachment 376362 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1327 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 28 2019-08-15 00:03:34 PDT

Created attachment 376365 [details] Patch

EWS Watchlist

Comment 29 2019-08-15 00:11:21 PDT

Attachment 376365 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1329 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 30 2019-08-15 01:06:44 PDT

Created attachment 376368 [details] Patch

EWS Watchlist

Comment 31 2019-08-15 01:12:04 PDT

Attachment 376368 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1331 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 32 2019-08-15 04:30:47 PDT

Comment on attachment 376368 [details] Patch Attachment 376368 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12916839 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-llint

Yusuke Suzuki

Comment 33 2019-08-15 13:46:01 PDT

Created attachment 376417 [details] Patch

EWS Watchlist

Comment 34 2019-08-15 13:52:45 PDT

Attachment 376417 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/FastMalloc.h:304: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/FastMalloc.h:310: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeap.h:85: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/bmalloc/bmalloc/IsoHeapInlines.h:126: __fastAllocatedClass is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 22 in 1331 files If any of these errors are false positives, please file a bug against check-webkit-style.

Geoffrey Garen

Comment 35 2019-08-15 14:17:18 PDT

Comment on attachment 376417 [details] Patch r=me Looks like this caught lots of optimization opportunities without adding undue complexity. Nice! Might be worth emailing webkit-dev to share this change in style. Probably good to let EWS finish before landing.

Darin Adler

Comment 36 2019-08-15 14:54:31 PDT

Comment on attachment 376417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376417&action=review There’s another way to stage this. A) Add WTF_MAKE_FAST_ALLOCATED because of things that we learned from making this change locally. B) Change callers from std::make_unique to WTF::makeUnique. C) Add the checking that makes it a compilation failure to use makeUnique without WTF_MAKE_FAST_ALLOCATED. What I like about this staging is that each patch is safe on its own, and can even be broken into multiple smaller pieces if needed. And patch C is small and easy to roll in and out. You can do it in the order A, B, C, or B, A, C, or any order as long as it culminates in C. > Source/WTF/wtf/FastMalloc.h:304 > +typedef int __fastAllocatedClass; \ Since this is new code, why not "using" instead of "typedef"? Let's not use "double underscore", which is reserved in the language; many other patterns are not reserved. > Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 > -class LegacyCDM { > +class LegacyCDM final { > + WTF_MAKE_FAST_ALLOCATED; One technique I have used in the past is to land all these changes separately first. Then

Darin Adler

Comment 37 2019-08-15 14:56:41 PDT

Comment on attachment 376417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376417&action=review Doing it all at once is probably OK too. Just harder to roll out if there’s a problem. I guess there’s also: D) Add a check-webkit-style verifier to complain if we use std::make_unique. E) Do some trick to make it a compiler error if we accidentally use std::make_unique. >> Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 >> + WTF_MAKE_FAST_ALLOCATED; > > One technique I have used in the past is to land all these changes separately first. Then I was just pointing out that this could be part of a patch (A) that I mentioned.

Alex Christensen

Comment 38 2019-08-15 16:00:03 PDT

Comment on attachment 376417 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376417&action=review > Source/WTF/benchmarks/LockFairnessTest.cpp:64 > + std::unique_ptr<unsigned[]> counts = makeUniqueWithoutFastMallocCheck<unsigned[]>(numThreads); Isn't this what makeUniqueArray is for?

Yusuke Suzuki

Comment 39 2019-08-15 16:15:36 PDT

(In reply to Darin Adler from comment #36) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > There’s another way to stage this. > > A) Add WTF_MAKE_FAST_ALLOCATED because of things that we learned from making > this change locally. > > B) Change callers from std::make_unique to WTF::makeUnique. > > C) Add the checking that makes it a compilation failure to use makeUnique > without WTF_MAKE_FAST_ALLOCATED. > > What I like about this staging is that each patch is safe on its own, and > can even be broken into multiple smaller pieces if needed. And patch C is > small and easy to roll in and out. > > You can do it in the order A, B, C, or B, A, C, or any order as long as it > culminates in C. This sounds nice! I'll mechanically split this patch into these pieces and land them separately for roll-out ease. > > > Source/WTF/wtf/FastMalloc.h:304 > > +typedef int __fastAllocatedClass; \ > > Since this is new code, why not "using" instead of "typedef"? Nice, fixed. > > Let's not use "double underscore", which is reserved in the language; many > other patterns are not reserved. I'll use very long word instead, like, `webkitFastAllocatedClass` etc. > > > Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 > > -class LegacyCDM { > > +class LegacyCDM final { > > + WTF_MAKE_FAST_ALLOCATED; > > One technique I have used in the past is to land all these changes > separately first. Then (In reply to Darin Adler from comment #37) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > Doing it all at once is probably OK too. Just harder to roll out if there’s > a problem. > > I guess there’s also: > > D) Add a check-webkit-style verifier to complain if we use std::make_unique. While I'll land separate three patches as A-C in this bug, I'll create a patch for D and upload it to a separate bug for review :) > > E) Do some trick to make it a compiler error if we accidentally use > std::make_unique. ThirdParty code (libwebrtc etc.) is still using std::make_unique, and the header having std::make_unique can be included in WebKit project, so maybe, it is difficult. > > >> Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDM.h:54 > >> + WTF_MAKE_FAST_ALLOCATED; > > > > One technique I have used in the past is to land all these changes separately first. Then > > I was just pointing out that this could be part of a patch (A) that I > mentioned. (In reply to Alex Christensen from comment #38) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > > Source/WTF/benchmarks/LockFairnessTest.cpp:64 > > + std::unique_ptr<unsigned[]> counts = makeUniqueWithoutFastMallocCheck<unsigned[]>(numThreads); > > Isn't this what makeUniqueArray is for? Right. Fixed :)

Yusuke Suzuki

Comment 40 2019-08-15 20:31:15 PDT

Created attachment 376470 [details] A: Annotation Patch

EWS Watchlist

Comment 41 2019-08-15 20:34:42 PDT

Attachment 376470 [details] did not pass style-queue: ERROR: Source/WebCore/platform/audio/DenormalDisabler.h:44: Failed to find complete declaration of class DenormalDisabler [build/class] [5] Total errors found: 1 in 405 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 42 2019-08-15 23:49:58 PDT

Tested iOS locally.

Yusuke Suzuki

Comment 43 2019-08-15 23:53:46 PDT

Committed r248762: <https://trac.webkit.org/changeset/248762>

Radar WebKit Bug Importer

Comment 44 2019-08-15 23:54:28 PDT

<rdar://problem/54379870>

Yusuke Suzuki

Comment 45 2019-08-15 23:56:34 PDT

(In reply to Yusuke Suzuki from comment #43) > Committed r248762: <https://trac.webkit.org/changeset/248762> "A" patch goes. I'll upload the "B" patch, and land it tomorrow. And after that, I'll land "C" patch. Then, announcing makeUnique in webkit-dev and open a new bug for "D" patch.

Yusuke Suzuki

Comment 46 2019-08-15 23:58:05 PDT

(In reply to Yusuke Suzuki from comment #45) > (In reply to Yusuke Suzuki from comment #43) > > Committed r248762: <https://trac.webkit.org/changeset/248762> > > "A" patch goes. I'll upload the "B" patch, and land it tomorrow. And after > that, I'll land "C" patch. Then, announcing makeUnique in webkit-dev and > open a new bug for "D" patch. One of the good thing this patch found is that we missed this annotation even in recent code, like Source/WebCore/layout/inlineformatting/InlineItem.h. After introducing makeUnique, we no longer have this!

Yusuke Suzuki

Comment 47 2019-08-16 02:04:41 PDT

Reopening to attach new patch.

Yusuke Suzuki

Comment 48 2019-08-16 02:05:49 PDT

Created attachment 376485 [details] B: makeUnique / makeUniqueWithoutFastMallocCheck

Yusuke Suzuki

Comment 49 2019-08-16 02:10:09 PDT

Created attachment 376486 [details] B: makeUnique / makeUniqueWithoutFastMallocCheck

EWS Watchlist

Comment 50 2019-08-16 02:17:05 PDT

Attachment 376486 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 17 in 1018 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 51 2019-08-18 23:11:59 PDT

(In reply to Alex Christensen from comment #38) > Comment on attachment 376417 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=376417&action=review > > > Source/WTF/benchmarks/LockFairnessTest.cpp:64 > > + std::unique_ptr<unsigned[]> counts = makeUniqueWithoutFastMallocCheck<unsigned[]>(numThreads); > > Isn't this what makeUniqueArray is for? Unfortunately, it seems that some of TestWebKit headers (maybe?) things are compiled without bmalloc, so we cannot use makeUniqueArray :(

Yusuke Suzuki

Comment 52 2019-08-18 23:44:56 PDT

Created attachment 376665 [details] B: makeUnique / makeUniqueWithoutFastMallocCheck

EWS Watchlist

Comment 53 2019-08-18 23:50:24 PDT

Attachment 376665 [details] did not pass style-queue: ERROR: Source/WebCore/page/UserContentController.cpp:76: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/page/UserContentController.cpp:103: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/fileapi/AsyncFileStream.cpp:97: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/layout/layouttree/LayoutBox.cpp:450: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:566: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:571: More than one command on the same line [whitespace/newline] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp:608: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/dom/KeyboardEvent.cpp:99: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:977: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:978: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:984: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/page/animation/CSSPropertyAnimation.cpp:985: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderObject.cpp:1896: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKitLegacy/Storage/StorageThread.cpp:90: Extra space before ( in function call [whitespace/parens] [4] WARNING: File exempt from style guide. Skipping: "Tools/TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp" ERROR: Source/WebCore/page/Page.cpp:273: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/platform/image-decoders/gif/GIFImageReader.cpp:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 17 in 1024 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yusuke Suzuki

Comment 54 2019-08-18 23:59:54 PDT

Committed r248846: <https://trac.webkit.org/changeset/248846>

Yusuke Suzuki

Comment 55 2019-08-19 00:16:03 PDT

Reopening to attach new patch.

Yusuke Suzuki

Comment 56 2019-08-19 00:16:04 PDT

Created attachment 376666 [details] C: makeUnique should perform static-assert

Yusuke Suzuki

Comment 57 2019-08-19 00:54:25 PDT

Created attachment 376672 [details] C: makeUnique should perform static-assert

EWS Watchlist

Comment 58 2019-08-19 02:03:12 PDT

Comment on attachment 376665 [details] B: makeUnique / makeUniqueWithoutFastMallocCheck Attachment 376665 [details] did not pass jsc-ews (mac): Output: https://webkit-queues.webkit.org/results/12939317 New failing tests: mozilla-tests.yaml/js1_5/Array/regress-101964.js.mozilla-llint

Yusuke Suzuki

Comment 59 2019-08-19 02:11:44 PDT

Committed r248850: <https://trac.webkit.org/changeset/248850>

Yusuke Suzuki

Comment 60 2019-08-19 02:41:08 PDT

Committed r248851: <https://trac.webkit.org/changeset/248851>

Yusuke Suzuki

Comment 61 2019-08-19 13:12:49 PDT

Committed r248861: <https://trac.webkit.org/changeset/248861>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Web Template Framework

Assignee

Yusuke Suzuki

Reported

2019-08-10 19:42 PDT

Modified

2019-08-19 13:12 PDT History

CC List

11 users Show

URL

Keywords InRadar

Depends on

200611

Blocks

200878

Dependencies

tree graph