Bug 200619 - WebPage and ViewportConfiguration have differing notions of viewLayoutSize
Summary: WebPage and ViewportConfiguration have differing notions of viewLayoutSize
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
Keywords: DoNotImportToRadar
Depends on:
Reported: 2019-08-10 19:26 PDT by Wenson Hsieh
Modified: 2019-08-11 16:17 PDT (History)
6 users (show)

See Also:

Patch (21.75 KB, patch)
2019-08-10 21:48 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-08-10 19:26:32 PDT
m_viewLayoutSize exists in both WebPage and ViewportConfiguration. However, they mean different things (ViewportConfiguration’s m_viewLayoutSize is about the size of the platform view, and WebPage’s m_viewLayoutSize is about special the autosizing/autolayout mode on macOS that’s guarded by SPI).

This makes some existing viewport configuration logic difficult to refactor and fix.
Comment 1 Wenson Hsieh 2019-08-10 21:48:01 PDT
Created attachment 376031 [details]
Comment 2 Wenson Hsieh 2019-08-10 21:49:25 PDT
(This is motivated by the fix for <rdar://problem/52694257>).
Comment 3 WebKit Commit Bot 2019-08-11 12:12:04 PDT
Comment on attachment 376031 [details]

Clearing flags on attachment: 376031

Committed r248522: <https://trac.webkit.org/changeset/248522>
Comment 4 WebKit Commit Bot 2019-08-11 12:12:05 PDT
All reviewed patches have been landed.  Closing bug.