RESOLVED FIXED 200601
Web Inspector: RTL: DOM outline in Elements tab should be LTR
https://bugs.webkit.org/show_bug.cgi?id=200601
Summary Web Inspector: RTL: DOM outline in Elements tab should be LTR
Nikita Vasilyev
Reported 2019-08-09 17:23:57 PDT
Created attachment 375985 [details] [Image] Bug Currently, HTML is garbled. A few examples: <div id="flatpage" class="flatpages"> shown as: <"div id="flatpage" class="flatpages"> --- <link href="https://static.npmjs.com/assets/cjz3o4s010001df74sudx2ja9/apos- minified/anon-cjz3o4s010001df74sudx2ja9.css" rel="stylesheet"> shown as: link href="https://static.npmjs.com/assets/cjz3o4s010001df74sudx2ja9/apos-> <"minified/anon-cjz3o4s010001df74sudx2ja9.css" rel="stylesheet
Attachments
[Image] Bug (80.16 KB, image/png)
2019-08-09 17:23 PDT, Nikita Vasilyev
no flags
Patch (7.61 KB, patch)
2019-08-16 15:51 PDT, Nikita Vasilyev
no flags
[Image] With patch applied (351.78 KB, image/png)
2019-08-16 15:55 PDT, Nikita Vasilyev
no flags
Nikita Vasilyev
Comment 1 2019-08-16 15:51:48 PDT
Nikita Vasilyev
Comment 2 2019-08-16 15:55:23 PDT
Created attachment 376553 [details] [Image] With patch applied
Timothy Hatcher
Comment 3 2019-08-21 18:34:39 PDT
Comment on attachment 376551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376551&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:47 > + this.element.dir = "ltr"; Set this in CSS instead?
Nikita Vasilyev
Comment 4 2019-08-21 18:40:40 PDT
Comment on attachment 376551 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376551&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:47 >> + this.element.dir = "ltr"; > > Set this in CSS instead? I set this as an attribute because there are CSS selectors that depend on it. For example, there's one that "unmirrors" disclosure triangles: body[dir=rtl] [dir=ltr] .tree-outline .item .disclosure-button { transform: unset; }
WebKit Commit Bot
Comment 5 2019-08-21 19:33:46 PDT
Comment on attachment 376551 [details] Patch Clearing flags on attachment: 376551 Committed r248991: <https://trac.webkit.org/changeset/248991>
WebKit Commit Bot
Comment 6 2019-08-21 19:33:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-08-21 19:34:17 PDT
Note You need to log in before you can comment on or make changes to this bug.