Bug 200598 - Web Inspector: Address some ESLint warnings
Summary: Web Inspector: Address some ESLint warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-09 16:22 PDT by Joseph Pecoraro
Modified: 2019-08-12 11:50 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (16.27 KB, patch)
2019-08-09 16:23 PDT, Joseph Pecoraro 		hi: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-08-09 16:22:27 PDT 
Address some ESLint warnings
Comment 1 Joseph Pecoraro 2019-08-09 16:23:38 PDT 
Created attachment 375977 [details]
[PATCH] Proposed Fix
Comment 2 Devin Rousso 2019-08-09 16:36:02 PDT 
Comment on attachment 375977 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=375977&action=review

r=me, awesome

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:734
> +        // FIXME: Return values from this are crazy.

I think this function can be removed entirely.  Nobody seems to call it :P
Comment 3 Joseph Pecoraro 2019-08-12 11:48:35 PDT 
> > Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:734
> > +        // FIXME: Return values from this are crazy.
> 
> I think this function can be removed entirely.  Nobody seems to call it :P

Yep! Nice
Comment 4 Joseph Pecoraro 2019-08-12 11:49:26 PDT 
https://trac.webkit.org/changeset/248537/webkit
Comment 5 Radar WebKit Bug Importer 2019-08-12 11:50:25 PDT 
<rdar://problem/54219071>