Bug 200595 - Fix WebKitLegacy's post-process-header-rule script to support paths with spaces in them
Summary: Fix WebKitLegacy's post-process-header-rule script to support paths with spac...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2019-08-09 15:44 PDT by Keith Rollin
Modified: 2019-08-09 16:52 PDT (History)
7 users (show)

See Also:

Patch (2.51 KB, patch)
2019-08-09 15:46 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-09 15:44:02 PDT
A number of scripts were added to WebKit, JavaScriptCore, and WebKitLegacy to support XCBuild's new facility for copying and modifying files in one atomic step. The first two are OK, but WebKitLegacy's script (post-process-header-rule) references a file via a variable named "header", and does so without quoting the variable's value. When the header's path contains spaces -- as can happen when building Safari Technology Preview -- the script breaks. Fix this by adding quoting.

Also fix a spot where post-process-header-rule expected that WebKitAvailability.h was referenced via a relative path for the form "./WebKitAvailability.h" rather than -- as is the case now -- an absolute path.

Comment 1 Keith Rollin 2019-08-09 15:45:03 PDT
Ignore that comment about WebKitAvailability.h. I'll be taking care of that in another patch.
Comment 2 Keith Rollin 2019-08-09 15:46:41 PDT
Created attachment 375972 [details]
Comment 3 WebKit Commit Bot 2019-08-09 16:52:20 PDT
Comment on attachment 375972 [details]

Clearing flags on attachment: 375972

Committed r248489: <https://trac.webkit.org/changeset/248489>
Comment 4 WebKit Commit Bot 2019-08-09 16:52:22 PDT
All reviewed patches have been landed.  Closing bug.