Bug 200594 - Web Inspector: Better organize manager / observer API groups
Summary: Web Inspector: Better organize manager / observer API groups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-09 15:42 PDT by Joseph Pecoraro
Modified: 2019-08-12 11:50 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (29.85 KB, patch)
2019-08-09 15:44 PDT, Joseph Pecoraro
drousso: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2019-08-09 15:42:52 PDT
Better organize manager / observer API groups

This moves us a bit closer to our preferred grouping:

    class FooManager extends WI.Object
    {
        constructor()

        // Agent
        
            domains

        // Target
        
            initializeTarget

        // Static
        
            supportsFooBar

        // Public
        
            add
            remove

        // FooObserver
        
            callbacks

        // Private
        
            internal API
    }
Comment 1 Joseph Pecoraro 2019-08-09 15:44:38 PDT
Created attachment 375970 [details]
[PATCH] Proposed Fix
Comment 2 Devin Rousso 2019-08-09 15:50:45 PDT
Comment on attachment 375970 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=375970&action=review

r=me, 1000% YES

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:570
> -    reset()
> +    globalObjectCleared()

I've never been happier with a change in all my life 😍

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:382
> +    // ConsoleObserver

What about `// ScriptProfilerObserver`?
Comment 3 Joseph Pecoraro 2019-08-12 11:42:19 PDT
> > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:382
> > +    // ConsoleObserver
> 
> What about `// ScriptProfilerObserver`?

Done!
Comment 4 Joseph Pecoraro 2019-08-12 11:49:08 PDT
https://trac.webkit.org/changeset/248536/webkit
Comment 5 Radar WebKit Bug Importer 2019-08-12 11:50:19 PDT
<rdar://problem/54219068>