Better organize manager / observer API groups This moves us a bit closer to our preferred grouping: class FooManager extends WI.Object { constructor() // Agent domains // Target initializeTarget // Static supportsFooBar // Public add remove // FooObserver callbacks // Private internal API }
Created attachment 375970 [details] [PATCH] Proposed Fix
Comment on attachment 375970 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=375970&action=review r=me, 1000% YES > Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:570 > - reset() > + globalObjectCleared() I've never been happier with a change in all my life 😍 > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:382 > + // ConsoleObserver What about `// ScriptProfilerObserver`?
> > Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:382 > > + // ConsoleObserver > > What about `// ScriptProfilerObserver`? Done!
https://trac.webkit.org/changeset/248536/webkit
<rdar://problem/54219068>