Bug 200591 - [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
Summary: [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-09 14:32 PDT by Wenson Hsieh
Modified: 2019-08-09 16:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.36 KB, patch)
2019-08-09 14:41 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (5.71 KB, patch)
2019-08-09 15:40 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-08-09 14:32:48 PDT 
<rdar://problem/54102238>
Comment 1 Wenson Hsieh 2019-08-09 14:41:55 PDT 
Created attachment 375961 [details]
Patch
Comment 2 Ryosuke Niwa 2019-08-09 14:53:03 PDT 
Comment on attachment 375961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826
> +    switch (_focusedElementInformation.elementType) {
> +    case WebKit::InputType::Password:

Either plain text field doesn't support pasting of an image,
or all these could potentially support pasting of an image if we rely on page's scripts.

r=me with this element type check removed as we discussed in person.
Comment 3 Wenson Hsieh 2019-08-09 15:38:16 PDT 
Comment on attachment 375961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375961&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6826
>> +    case WebKit::InputType::Password:
> 
> Either plain text field doesn't support pasting of an image,
> or all these could potentially support pasting of an image if we rely on page's scripts.
> 
> r=me with this element type check removed as we discussed in person.

Thanks for the review!

I’ll need to adjust this patch a little more after some feedback from UIKit folks (moving the SPI to the UITextInputPrivate protocol instead)
Comment 4 Wenson Hsieh 2019-08-09 15:40:03 PDT 
Created attachment 375969 [details]
Patch
Comment 5 Wenson Hsieh 2019-08-09 16:07:02 PDT 
Landed <https://trac.webkit.org/r248487>.