Bug 200588 - [iOS WK2] Remove context menu hints on navigation
Summary: [iOS WK2] Remove context menu hints on navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-09 14:07 PDT by Simon Fraser (smfr)
Modified: 2019-08-10 16:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.64 KB, patch)
2019-08-09 14:08 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff
Patch (4.89 KB, patch)
2019-08-09 14:19 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-08-09 14:07:04 PDT
[iOS WK2] Remove context menu previews on navigation
Comment 1 Simon Fraser (smfr) 2019-08-09 14:08:36 PDT
Created attachment 375950 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-08-09 14:08:38 PDT
<rdar://problem/54061796>
Comment 3 Tim Horton 2019-08-09 14:10:38 PDT
Comment on attachment 375950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375950&action=review

> Source/WebKit/ChangeLog:9
> +        Make sure the context menu preview doesn't linger across navigations by hosting it in its

hint! the preview is the platter that is presented above the context menu.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3954
> +    [self _hideContextMenu];

You don't hide the menu, just the hint

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6397
> +    if (_contextMenuContainerView) {

Ditto
Comment 4 Simon Fraser (smfr) 2019-08-09 14:19:51 PDT
Created attachment 375956 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-09 15:01:46 PDT
Comment on attachment 375956 [details]
Patch

Clearing flags on attachment: 375956

Committed r248481: <https://trac.webkit.org/changeset/248481>
Comment 6 Alexey Proskuryakov 2019-08-09 15:30:09 PDT
Comment on attachment 375956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375956&action=review

> Source/WebKit/ChangeLog:15
> +        (-[WKContentView _didCommitLoadForMainFrame]):

The issue will still be happening for subframe navigations, correct?
Comment 7 Simon Fraser (smfr) 2019-08-10 16:54:56 PDT
Yes, but we can fix that separately.