Bug 200588 – [iOS WK2] Remove context menu hints on navigation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

[iOS WK2] Remove context menu previews on navigation

[Simon Fraser (smfr)]

Created attachment 375950 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/54061796>

[Tim Horton]

Comment on attachment 375950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375950&action=review

> Source/WebKit/ChangeLog:9
> +        Make sure the context menu preview doesn't linger across navigations by hosting it in its

hint! the preview is the platter that is presented above the context menu.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3954
> +    [self _hideContextMenu];

You don't hide the menu, just the hint

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6397
> +    if (_contextMenuContainerView) {

Ditto

[Simon Fraser (smfr)]

Created attachment 375956 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375956 [details]
Patch

Clearing flags on attachment: 375956

Committed r248481: <https://trac.webkit.org/changeset/248481>

[Alexey Proskuryakov]

Comment on attachment 375956 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375956&action=review

> Source/WebKit/ChangeLog:15
> +        (-[WKContentView _didCommitLoadForMainFrame]):

The issue will still be happening for subframe navigations, correct?

[Simon Fraser (smfr)]

Yes, but we can fix that separately.