Bug 200587 – Web Inspector: REGRESSION(r248454): WK1 inspector frontend client doesn't queue messages to the frontend before it's loaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

WK1 inspector pipes messages to the frontend using `WebCore::InspectorClient::doDispatchMessageOnFrontendPage`, which does NOT do any sort of queueing to wait until the frontend is loaded (`InspectorFrontendHost.loaded()`).  Now that we are sending messages immediately, we should always queue.

[Devin Rousso]

Created attachment 375954 [details]
Patch

[Devin Rousso]

I think this might also fix the test failures for <https://webkit.org/b/200110>.

[Joseph Pecoraro]

Comment on attachment 375954 [details]
Patch

r=me assuming tests pass!

[EWS Watchlist]

Comment on attachment 375954 [details]
Patch

Attachment 375954 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/12887347

New failing tests:
inspector/debugger/break-in-constructor-before-super.html
inspector/debugger/breakpoint-eval-with-exception.html
inspector/debugger/setBreakpointByUrl-sourceURL.html
inspector/debugger/evaluateOnCallFrame-errors.html
inspector/debugger/pause-on-assert.html
inspector/debugger/setBreakpoint-condition.html
inspector/debugger/regress-133182.html
inspector/debugger/setBreakpoint-column.html

[EWS Watchlist]

Created attachment 375967 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 375954 [details]
Patch

Attachment 375954 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/12887581

New failing tests:
inspector/debugger/breakpoint-eval-with-exception.html
inspector/debugger/setBreakpointByUrl-sourceURL.html
inspector/debugger/evaluateOnCallFrame-errors.html
inspector/debugger/pause-on-assert.html
inspector/debugger/setBreakpoint-condition.html
inspector/debugger/regress-133182.html
inspector/debugger/setBreakpoint-column.html

[EWS Watchlist]

Created attachment 375979 [details]
Archive of layout-test-results from ews114 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Devin Rousso]

Created attachment 375996 [details]
Patch

Add additional code which I mistakenly forgot to copy from `doDispatchMessageOnFrontendPage`

[WebKit Commit Bot]

Comment on attachment 375996 [details]
Patch

Clearing flags on attachment: 375996

Committed r248497: <https://trac.webkit.org/changeset/248497>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54156422>