User Agent and SessionID should be given to NetworkRTCProvider to set up the correct proxy information
Created attachment 375938 [details] Patch
Patch needs manual testing
<rdar://problem/54135396>
Attachment 375938 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:121: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376053 [details] Patch
Attachment 376053 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:121: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376055 [details] Patch
Attachment 376055 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:121: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376070 [details] Patch
Attachment 376070 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:121: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 376072 [details] Patch
Attachment 376072 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:121: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to youenn fablet from comment #11) > Created attachment 376072 [details] > Patch Tested on Mac, not yet on iOS.
Comment on attachment 376072 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=376072&action=review > Source/WebCore/ChangeLog:8 > + Use a specific socket factory that is specific to the user agent and session ID. Nit: s/a specific socket factory/a socket factory/ > Source/WebKit/ChangeLog:9 > + Use of this information to get the proxy information from NetworkSession and pass it to libwebrtc socket creation. Nit: s/Use of this/Use this/ > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:31 > +OBJC_CLASS NSURLSessionConfiguration; Nit: it doesn't look like this is needed (yet)
Created attachment 376140 [details] Patch for landing
Attachment 376140 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h:121: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 376140 [details] Patch for landing Clearing flags on attachment: 376140 Committed r248592: <https://trac.webkit.org/changeset/248592>
All reviewed patches have been landed. Closing bug.