Bug 200573 - Can’t sort videos on a YouTube channel page on iPad
Summary: Can’t sort videos on a YouTube channel page on iPad
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-09 07:02 PDT by Antti Koivisto
Modified: 2019-08-10 03:38 PDT (History)
5 users (show)

See Also:


Attachments
patch (2.46 KB, patch)
2019-08-09 07:47 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (2.46 KB, patch)
2019-08-09 07:53 PDT, Antti Koivisto
darin: review+
Details | Formatted Diff | Diff
patch (2.45 KB, patch)
2019-08-10 01:38 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-08-09 07:02:40 PDT
Because preventDefault() from touch event handler.
Comment 1 Antti Koivisto 2019-08-09 07:11:50 PDT
<rdar://problem/53415195>
Comment 2 Antti Koivisto 2019-08-09 07:47:09 PDT
Created attachment 375916 [details]
patch
Comment 3 Build Bot 2019-08-09 07:50:05 PDT
Attachment 375916 [details] did not pass style-queue:


ERROR: Source/WebCore/page/Quirks.cpp:351:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/page/Quirks.cpp:351:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Antti Koivisto 2019-08-09 07:53:10 PDT
Created attachment 375919 [details]
patch
Comment 5 Anders Carlsson 2019-08-09 08:47:34 PDT
Comment on attachment 375919 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375919&action=review

> Source/WebCore/ChangeLog:9
> +        Add a quick to make touch events non-cancelable (preventDefault() does nothing.

Typo, quick.
Comment 6 Darin Adler 2019-08-09 09:27:54 PDT
Comment on attachment 375919 [details]
patch

I don’t see the code calling the new function.
Comment 7 Geoffrey Garen 2019-08-09 10:08:37 PDT
Comment on attachment 375919 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375919&action=review

r=me

>> Source/WebCore/ChangeLog:9
>> +        Add a quick to make touch events non-cancelable (preventDefault() does nothing.
> 
> Typo, quick.

As long as we're piling on tyops, let's put a ) at the end of the sentence :P.
Comment 8 Geoffrey Garen 2019-08-09 10:09:10 PDT
Comment on attachment 375919 [details]
patch

Oh yeah, Darin has a point: We should probably call this function.
Comment 9 Antti Koivisto 2019-08-09 11:36:46 PDT
Theres is an internal patch that calls the function.
Comment 10 Antti Koivisto 2019-08-10 01:38:23 PDT
Created attachment 376003 [details]
patch
Comment 11 WebKit Commit Bot 2019-08-10 03:38:07 PDT
Comment on attachment 376003 [details]
patch

Clearing flags on attachment: 376003

Committed r248499: <https://trac.webkit.org/changeset/248499>
Comment 12 WebKit Commit Bot 2019-08-10 03:38:08 PDT
All reviewed patches have been landed.  Closing bug.