Bug 200571 – Pass a ScriptExecutionContext as input to register/unregister URLRegistry routines

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[youenn fablet]

Pass a ScriptExecutionContext as input to register/unregister URLRegistry routines

[youenn fablet]

Created attachment 375907 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/54123571>

[Darin Adler]

Comment on attachment 375907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375907&action=review

> Source/WebCore/html/PublicURLManager.cpp:54
> +    found->key->registerURL(*scriptExecutionContext(), url, registrable);

What guarantees it’s non-null?

> Source/WebCore/html/PublicURLManager.cpp:62
> +            registry.key->unregisterURL(*scriptExecutionContext(), url);

What guarantees it’s non-null?

> Source/WebCore/html/PublicURLManager.cpp:77
> +            registry.key->unregisterURL(*scriptExecutionContext(), URL({ }, url));

What guarantees it’s non-null?

[youenn fablet]

Thanks for the review.

(In reply to Darin Adler from comment #3)
> Comment on attachment 375907 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375907&action=review
> 
> > Source/WebCore/html/PublicURLManager.cpp:54
> > +    found->key->registerURL(*scriptExecutionContext(), url, registrable);
> 
> What guarantees it’s non-null?

PublicURLManager is an ActiveDOMObject and all call sites doing '*scriptExecutionContext()' cannot be called after the manager is stopped or are no-op once the manager is stopped (all urls are cleared).

[youenn fablet]

Created attachment 375945 [details]
Rebasing

[WebKit Commit Bot]

Comment on attachment 375945 [details]
Rebasing

Clearing flags on attachment: 375945

Committed r248473: <https://trac.webkit.org/changeset/248473>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.