Bug 20056 - [XBL] XBLCachedDocument cleanup
Summary: [XBL] XBLCachedDocument cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-16 09:48 PDT by Julien Chaffraix
Modified: 2008-07-23 13:28 PDT (History)
0 users

See Also:

Attachments
Proposed cleanup (11.30 KB, patch)
2008-07-16 09:51 PDT, Julien Chaffraix 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2008-07-16 09:48:08 PDT 
The current version uses old APIs (some of them removed). It has also some coding style violations.
Comment 1 Julien Chaffraix 2008-07-16 09:51:07 PDT 
Created attachment 22309 [details]
Proposed cleanup
Comment 2 Eric Seidel (no email) 2008-07-22 08:37:20 PDT 
Comment on attachment 22309 [details]
Proposed cleanup

I think:
5         RefPtr<WebCore::XBLDocument> document() const { return m_document; }

Should probably return PassRefPtr, no?  PassRefPtr will automatically copy from RefPtr in this case, but there will be no additional ref churn on assignment.  Otherwise looks fine.
Comment 3 Julien Chaffraix 2008-07-23 13:27:00 PDT 
Committed in r35299.
Comment 4 Julien Chaffraix 2008-07-23 13:28:31 PDT 
> Should probably return PassRefPtr, no?  PassRefPtr will automatically copy from
> RefPtr in this case, but there will be no additional ref churn on assignment. 

I think so too so I switched to PassRefPtr before landing.