RESOLVED FIXED 20056
[XBL] XBLCachedDocument cleanup 
https://bugs.webkit.org/show_bug.cgi?id=20056
Summary [XBL] XBLCachedDocument cleanup
Julien Chaffraix
Reported 2008-07-16 09:48:08 PDT
The current version uses old APIs (some of them removed). It has also some coding style violations.
Attachments
Proposed cleanup (11.30 KB, patch)
2008-07-16 09:51 PDT, Julien Chaffraix 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-07-16 09:51:07 PDT
Created attachment 22309 [details] Proposed cleanup
Eric Seidel (no email)
Comment 2 2008-07-22 08:37:20 PDT
Comment on attachment 22309 [details] Proposed cleanup I think: 5 RefPtr<WebCore::XBLDocument> document() const { return m_document; } Should probably return PassRefPtr, no? PassRefPtr will automatically copy from RefPtr in this case, but there will be no additional ref churn on assignment. Otherwise looks fine.
Julien Chaffraix
Comment 3 2008-07-23 13:27:00 PDT
Committed in r35299.
Julien Chaffraix
Comment 4 2008-07-23 13:28:31 PDT
> Should probably return PassRefPtr, no? PassRefPtr will automatically copy from > RefPtr in this case, but there will be no additional ref churn on assignment. I think so too so I switched to PassRefPtr before landing.
Note You need to log in before you can comment on or make changes to this bug.