Bug 200555 - Web Inspector: Elements: Computed: move the Box Model section to the top
Summary: Web Inspector: Elements: Computed: move the Box Model section to the top
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-08 17:46 PDT by Devin Rousso
Modified: 2019-08-14 12:35 PDT (History)
6 users (show)

See Also:


Attachments
Patch (7.91 KB, patch)
2019-08-08 17:59 PDT, Devin Rousso
joepeck: review+
Details | Formatted Diff | Diff
[Image] After Patch is applied (144.10 KB, image/png)
2019-08-08 18:00 PDT, Devin Rousso
no flags Details
Patch (2.54 KB, patch)
2019-08-14 10:37 PDT, Devin Rousso
drousso: commit-queue+
Details | Formatted Diff | Diff
Patch (2.54 KB, patch)
2019-08-14 10:43 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-08-08 17:46:14 PDT
For nodes that set a LOT of CSS properties, having the Box Model section waaay at the bottom may not be as useful for a quick glance.  Bringing it to the top makes it much more visible, and it's still collapsable if the developer doesn't actually want to see it at all.
Comment 1 Devin Rousso 2019-08-08 17:59:37 PDT
Created attachment 375873 [details]
Patch
Comment 2 Devin Rousso 2019-08-08 18:00:10 PDT
Created attachment 375874 [details]
[Image] After Patch is applied

The colors are the same as they were previously in Dark mode.
Comment 3 Joseph Pecoraro 2019-08-14 10:08:00 PDT
Comment on attachment 375873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review

This may make sense given it is a fixed size. I think we can give it a shot. r=me

> Source/WebInspectorUI/ChangeLog:14
> +        Drive-by: use a different identifier string for the Variable section so it preserves its own
> +                  collapsed state independent of the Properties section.

All of these drive-bys could have been its own bug.
Comment 4 Devin Rousso 2019-08-14 10:14:50 PDT
Comment on attachment 375873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review

>> Source/WebInspectorUI/ChangeLog:14
>> +                  collapsed state independent of the Properties section.
> 
> All of these drive-bys could have been its own bug.

True... I'll create separate bugs for each :)
Comment 5 Devin Rousso 2019-08-14 10:37:46 PDT
Created attachment 376279 [details]
Patch
Comment 6 Devin Rousso 2019-08-14 10:43:04 PDT
Created attachment 376282 [details]
Patch

Oops.  That's what I get for trying to manually edit a diff 🤦‍♂️
Comment 7 WebKit Commit Bot 2019-08-14 11:45:11 PDT
Comment on attachment 376282 [details]
Patch

Clearing flags on attachment: 376282

Committed r248683: <https://trac.webkit.org/changeset/248683>
Comment 8 WebKit Commit Bot 2019-08-14 11:45:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-08-14 11:46:22 PDT
<rdar://problem/54312008>
Comment 10 Brian Burg 2019-08-14 12:35:29 PDT
LGTM.