Bug 200552 - [iOS WK2] Hide previews when an inner overflow or frame scrollview scrolls
Summary: [iOS WK2] Hide previews when an inner overflow or frame scrollview scrolls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-08 16:24 PDT by Simon Fraser (smfr)
Modified: 2019-08-10 16:54 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.05 KB, patch)
2019-08-08 16:25 PDT, Simon Fraser (smfr)
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch (3.10 KB, patch)
2019-08-08 16:53 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (3.10 KB, patch)
2019-08-08 17:08 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-08-08 16:24:45 PDT
[iOS WK2] Hide previews when an inner overflow or frame scrollview scrolls
Comment 1 Simon Fraser (smfr) 2019-08-08 16:25:50 PDT
Created attachment 375855 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-08-08 16:25:52 PDT
<rdar://problem/54086338>
Comment 3 Wenson Hsieh 2019-08-08 16:32:26 PDT
Comment on attachment 375855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375855&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:8189
> +        UIScrollView* positionTrackingView = _webView.scrollView;

Nit - * on the other side.
Comment 4 Simon Fraser (smfr) 2019-08-08 16:53:11 PDT
Created attachment 375861 [details]
Patch
Comment 5 Simon Fraser (smfr) 2019-08-08 17:08:43 PDT
Created attachment 375864 [details]
Patch
Comment 6 WebKit Commit Bot 2019-08-08 18:57:55 PDT
Comment on attachment 375864 [details]
Patch

Clearing flags on attachment: 375864

Committed r248455: <https://trac.webkit.org/changeset/248455>