When a line is highlighted (e.g : after a click in the profile panel), there's not enough time for the user to see it.
Created attachment 22308 [details] Patch to restore the fade out
In addition to this fix, I also suggest to increase the effect time. Either the time with the className or the transition.
Comment on attachment 22308 [details] Patch to restore the fade out Why not move the "-webkit-transition-property: background-color; -webkit-transition-duration: 1s;" style properties to the normal ".webkit-line-content" rule a couple of lines above? That should remove the need to set the inline transition styles. r- until that is changed, unless there is a reason it can't be that way.
Two reasons: aroben told me that the desired effect was only a fade out. With the transition on the CSS rule, it would have been a fade in and out. And even if we want to change for a fade in and out, this rule cause an effect from black to white when the HTML source is created.
(In reply to comment #4) > Two reasons: > aroben told me that the desired effect was only a fade out. With the transition > on the CSS rule, it would have been a fade in and out. > And even if we want to change for a fade in and out, this rule cause an effect > from black to white when the HTML source is created. > I see. Then I would recommend adding a new CSS class rule that "turns" on the transitions, and add the class after "webkit-highlighted-line" is added. Then remove both classes after the timeout.
Created attachment 22358 [details] Patch with a class for fade out I've added the class. But I'm concerned about classes in this file. It will be difficult for other ports to style the inspector differently.
(In reply to comment #6) > Created an attachment (id=22358) [edit] > Patch with a class for fade out > > I've added the class. But I'm concerned about classes in this file. It will be > difficult for other ports to style the inspector differently. > I agree but it is no better than the inline style.
Of course, inline styles are worst. I was just comparing with an external CSS file.
Landed in r35382.
Reopen this bug because no decision was taken about making this effect longer.
I think a fade of 2s or 3s would be fine.
I mean fade in 2 or 3s.
If the patch that was landed did not address this bug, why was it attached to this bug report?
Comment on attachment 22358 [details] Patch with a class for fade out Clearing the review flag as the patch has been landed.
(In reply to comment #12) > I mean fade in 2 or 3s. > You mean fade out, since there's no fade in. (In reply to comment #13) > If the patch that was landed did not address this bug, why was it attached to > this bug report? > The patch adressed one part of the bug.
Created attachment 22665 [details] Increase the highlighted time
Fixed in r35633.