Bug 200548 - Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
Summary: Add a test to ensure that we dispatch keydown and keyup events when multiple ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2019-08-08 15:10 PDT by Daniel Bates
Modified: 2019-08-12 10:15 PDT (History)
2 users (show)

See Also:

Patch (12.46 KB, patch)
2019-08-08 15:13 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-08-08 15:10:24 PDT
Add a test to ensure the following:

1. When a person presses e, g and releases e, g (in that order) that the DOM keydown and keyup events are dispatches in the same order as the key were pressed and released.
2. Ensure (1) when the keys are left Option and right Option.
Comment 1 Daniel Bates 2019-08-08 15:13:56 PDT
Created attachment 375844 [details]
Comment 2 Darin Adler 2019-08-09 09:49:09 PDT
Comment on attachment 375844 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=375844&action=review

> LayoutTests/platform/ios/TestExpectations:3361
> +# Skip until we have the fixes for <rdar://problem/53613454> and <rdar://problem/54001139>.
> +fast/events/ios/multiple-key-press-and-release-ordering.html [ Skip ]

Why not expect a failure instead of skipping?
Comment 3 Daniel Bates 2019-08-09 14:05:46 PDT
Because its failure mode is a time out 😀. I had two options because of that:

1. Make test wait minimum amount of time before declaring failure
2. Mark the test as timeout in expectations

Both options have disadvantages though I was really leaning towards (2) because it's not extra work for me. I chose not to do (2) because someone once told me not to because "machines have limited resources" reasons. Not sure if that is true anymore.😕
Comment 4 Darin Adler 2019-08-09 15:48:34 PDT
Skip seems fine for a timeout that will be fixed soon.
Comment 5 Daniel Bates 2019-08-12 10:14:02 PDT
Comment on attachment 375844 [details]

Clearing flags on attachment: 375844

Committed r248531: <https://trac.webkit.org/changeset/248531>
Comment 6 Daniel Bates 2019-08-12 10:14:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-12 10:15:18 PDT