Bug 200527 - Move classes declared inside StorageManager.cpp into their own headers
Summary: Move classes declared inside StorageManager.cpp into their own headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-07 19:18 PDT by Chris Dumez
Modified: 2019-08-08 09:48 PDT (History)
8 users (show)

See Also:


Attachments
Patch (71.34 KB, patch)
2019-08-07 19:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (71.27 KB, patch)
2019-08-08 09:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-08-07 19:18:32 PDT
Move classes declared inside StorageManager.cpp into their own headers.
Comment 1 Chris Dumez 2019-08-07 19:19:58 PDT
Created attachment 375777 [details]
Patch
Comment 2 Alex Christensen 2019-08-08 08:57:49 PDT
Comment on attachment 375777 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375777&action=review

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:37
> +// FIXME: The quota value is copied from GroupSettings.cpp.

I'm not sure this comment is current.  This file doesn't exist any more.

> Source/WebKit/NetworkProcess/WebStorage/StorageArea.cpp:40
> +    : m_localStorageNamespace(localStorageNamespace ? makeWeakPtr(*localStorageNamespace) : nullptr)

Can't we just use the makeWeakPtr overload that takes a pointer now?

> Source/WebKit/NetworkProcess/WebStorage/TransientLocalStorageNamespace.h:55
> +    const unsigned m_quotaInBytes;

There are many of these that don't have default initializers in the headers.  It might be worth adding some.
Comment 3 Chris Dumez 2019-08-08 09:03:07 PDT
Created attachment 375806 [details]
Patch
Comment 4 WebKit Commit Bot 2019-08-08 09:47:03 PDT
Comment on attachment 375806 [details]
Patch

Clearing flags on attachment: 375806

Committed r248422: <https://trac.webkit.org/changeset/248422>
Comment 5 WebKit Commit Bot 2019-08-08 09:47:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-08 09:48:18 PDT
<rdar://problem/54083615>