...
Created attachment 375757 [details] patch
Attachment 375757 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 375758 [details] patch
Comment on attachment 375758 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=375758&action=review I think this patch also makes the ReachableFunctionGatherer that runs later obsolete since it will only ever receive reachable functions. > Source/WebCore/Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp:82 > + if (function->entryPointType() || function->parsingMode() != ParsingMode::StandardLibrary) I don't think you need the first part of this check: the entryPointType is certainly user-defined, no?
(In reply to Robin Morisset from comment #4) > Comment on attachment 375758 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375758&action=review > > I think this patch also makes the ReachableFunctionGatherer that runs later > obsolete since it will only ever receive reachable functions. > Not quite. That also prunes native functions. > > Source/WebCore/Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp:82 > > + if (function->entryPointType() || function->parsingMode() != ParsingMode::StandardLibrary) > > I don't think you need the first part of this check: the entryPointType is > certainly user-defined, no? Yes this is true. I just thought it's nice to call it out explicitly, but I can assert instead.
(In reply to Saam Barati from comment #5) > (In reply to Robin Morisset from comment #4) > > Comment on attachment 375758 [details] > > patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=375758&action=review > > > > I think this patch also makes the ReachableFunctionGatherer that runs later > > obsolete since it will only ever receive reachable functions. > > > Not quite. That also prunes native functions. More importantly, we can prune non stdlib functions later on. > > > > Source/WebCore/Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp:82 > > > + if (function->entryPointType() || function->parsingMode() != ParsingMode::StandardLibrary) > > > > I don't think you need the first part of this check: the entryPointType is > > certainly user-defined, no? > Yes this is true. I just thought it's nice to call it out explicitly, but I > can assert instead.
Comment on attachment 375758 [details] patch r=me
Created attachment 375763 [details] patch for landing
Comment on attachment 375763 [details] patch for landing Clearing flags on attachment: 375763 Committed r248403: <https://trac.webkit.org/changeset/248403>
All reviewed patches have been landed. Closing bug.
<rdar://problem/54067367>