Bug 200514 - Remove speculative workaround for upload crash
Summary: Remove speculative workaround for upload crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-07 12:42 PDT by Alex Christensen
Modified: 2019-08-07 16:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2019-08-07 12:43 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2019-08-07 13:05 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2019-08-07 13:05 PDT, Alex Christensen 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
patch (1.70 KB, patch)
2019-08-07 13:57 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-08-07 12:42:51 PDT 
Remove speculative workaround for upload crash
Comment 1 Alex Christensen 2019-08-07 12:43:26 PDT 
Created attachment 375733 [details]
Patch
Comment 2 John Wilander 2019-08-07 13:02:45 PDT 
Build failures on both Mac and iOS bots looks like a real issue. Other than that, the patch looks good to me.
Comment 3 Alex Christensen 2019-08-07 13:05:08 PDT 
Created attachment 375739 [details]
Patch
Comment 4 Alex Christensen 2019-08-07 13:05:17 PDT 
Created attachment 375741 [details]
Patch
Comment 5 John Wilander 2019-08-07 13:07:39 PDT 
Someone is going to complain that I'm not a reviewer. :) Someone needs to nominate me, I think.
Comment 6 WebKit Commit Bot 2019-08-07 13:33:16 PDT 
Comment on attachment 375741 [details]
Patch

Rejecting attachment 375741 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 375741, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

John Wilander found in /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/12875172
Comment 7 Alex Christensen 2019-08-07 13:57:10 PDT 
Created attachment 375749 [details]
patch
Comment 8 Geoffrey Garen 2019-08-07 13:59:13 PDT 
Comment on attachment 375749 [details]
patch

r=me
Comment 9 WebKit Commit Bot 2019-08-07 16:36:33 PDT 
Comment on attachment 375749 [details]
patch

Clearing flags on attachment: 375749

Committed r248394: <https://trac.webkit.org/changeset/248394>
Comment 10 WebKit Commit Bot 2019-08-07 16:36:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-08-07 16:37:56 PDT 
<rdar://problem/54056423>