RESOLVED LATER 200508
RegisterSet should be constexpr 
https://bugs.webkit.org/show_bug.cgi?id=200508
Summary RegisterSet should be constexpr
Keith Miller
Reported 2019-08-07 11:14:55 PDT
RegisterSet should be constexpr
Attachments
Patch (52.18 KB, patch)
2019-08-07 11:16 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (52.33 KB, patch)
2019-08-07 11:36 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (52.33 KB, patch)
2019-08-07 11:38 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (52.23 KB, patch)
2019-08-07 11:50 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (53.20 KB, patch)
2019-08-07 12:51 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (53.29 KB, patch)
2019-08-07 14:09 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-08-07 11:16:07 PDT
Created attachment 375716 [details] Patch
Saam Barati
Comment 2 2019-08-07 11:19:23 PDT
Comment on attachment 375716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375716&action=review very nice > Source/JavaScriptCore/jit/RegisterSet.h:251 > +namespace JSC { style nit: newline after this > Source/JavaScriptCore/jit/RegisterSet.h:545 > +} nit: // namespace JSC
Keith Miller
Comment 3 2019-08-07 11:36:58 PDT
Created attachment 375723 [details] Patch for landing
Keith Miller
Comment 4 2019-08-07 11:38:16 PDT
Created attachment 375725 [details] Patch
Keith Miller
Comment 5 2019-08-07 11:50:18 PDT
Created attachment 375727 [details] Patch
Keith Miller
Comment 6 2019-08-07 12:51:27 PDT
Created attachment 375734 [details] Patch
Keith Miller
Comment 7 2019-08-07 14:09:28 PDT
Created attachment 375752 [details] Patch
Keith Miller
Comment 8 2019-08-07 14:57:27 PDT
Nvm, we can't do this because old Clang is broken... :(
Note You need to log in before you can comment on or make changes to this bug.