Bug 200508 - RegisterSet should be constexpr
Summary: RegisterSet should be constexpr
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-07 11:14 PDT by Keith Miller
Modified: 2019-08-07 14:57 PDT (History)
9 users (show)

See Also:

Attachments
Patch (52.18 KB, patch)
2019-08-07 11:16 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (52.33 KB, patch)
2019-08-07 11:36 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (52.33 KB, patch)
2019-08-07 11:38 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (52.23 KB, patch)
2019-08-07 11:50 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (53.20 KB, patch)
2019-08-07 12:51 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (53.29 KB, patch)
2019-08-07 14:09 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-08-07 11:14:55 PDT 
RegisterSet should be constexpr
Comment 1 Keith Miller 2019-08-07 11:16:07 PDT 
Created attachment 375716 [details]
Patch
Comment 2 Saam Barati 2019-08-07 11:19:23 PDT 
Comment on attachment 375716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375716&action=review

very nice

> Source/JavaScriptCore/jit/RegisterSet.h:251
> +namespace JSC {

style nit: newline after this

> Source/JavaScriptCore/jit/RegisterSet.h:545
> +}

nit: // namespace JSC
Comment 3 Keith Miller 2019-08-07 11:36:58 PDT 
Created attachment 375723 [details]
Patch for landing
Comment 4 Keith Miller 2019-08-07 11:38:16 PDT 
Created attachment 375725 [details]
Patch
Comment 5 Keith Miller 2019-08-07 11:50:18 PDT 
Created attachment 375727 [details]
Patch
Comment 6 Keith Miller 2019-08-07 12:51:27 PDT 
Created attachment 375734 [details]
Patch
Comment 7 Keith Miller 2019-08-07 14:09:28 PDT 
Created attachment 375752 [details]
Patch
Comment 8 Keith Miller 2019-08-07 14:57:27 PDT 
Nvm, we can't do this because old Clang is broken... :(