Bug 200493 - [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
Summary: [WinCairo][WK1] A browser window starts as an inactive window because Acceler...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-06 19:33 PDT by Fujii Hironori
Modified: 2019-08-19 18:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.67 KB, patch)
2019-08-06 19:40 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-08-06 19:33:06 PDT
[WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window

MiniBrowser.exe --wk1 starts MiniBrowser as a inactive window.
Comment 1 Fujii Hironori 2019-08-06 19:34:28 PDT
Per, can I revert your r179962?
Comment 2 Fujii Hironori 2019-08-06 19:40:17 PDT
Created attachment 375676 [details]
Patch
Comment 3 Per Arne Vollan 2019-08-07 11:17:24 PDT
(In reply to Fujii Hironori from comment #1)
> Per, can I revert your r179962?

I think I would prefer to keep it, since there will be no drawing without it when accelerated compositing is not available.

Maybe the temporary window could be created with a different style?

From the current style, it seems it won't get activated.
Comment 4 Fujii Hironori 2019-08-08 23:34:36 PDT
I found a serious issue of AcceleratedCompositingContext::acceleratedCompositingAvailable on Windows 10 version 1809 or newer (Bug 200563).
I can't find a solution for both issues (Bug 200563 and Bug 200493).
Let's revert it until someone wants to solve these issues and the original issue (Bug 140667).
Comment 5 Fujii Hironori 2019-08-19 18:58:29 PDT
Comment on attachment 375676 [details]
Patch

Clearing flags on attachment: 375676

Committed r248885: <https://trac.webkit.org/changeset/248885>
Comment 6 Fujii Hironori 2019-08-19 18:58:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-19 18:59:22 PDT
<rdar://problem/54494703>