Bug 200490 - Extra space inserted at start of line when inserting a newline in Mail compose
Summary: Extra space inserted at start of line when inserting a newline in Mail compose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-06 16:57 PDT by Wenson Hsieh
Modified: 2019-08-07 09:24 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.96 KB, patch)
2019-08-06 17:57 PDT, Wenson Hsieh
koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (8.86 KB, patch)
2019-08-07 08:16 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-08-06 16:57:00 PDT
<rdar://problem/53501354>
Comment 1 Wenson Hsieh 2019-08-06 17:57:32 PDT
Created attachment 375673 [details]
Patch
Comment 2 Wenson Hsieh 2019-08-06 19:25:02 PDT
> perl Tools/Scripts/svn-apply --force .buildbot-diff
>  in dir C:\Buildbot\WinCairo-EWS\build (timeout 300 secs)
> ...
> patch: **** Can't create file C:\Users\ContainerAdministrator\AppData\Local\Temp/ppz02368 : File exists
> fatal: pathspec 'LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html' did not match any files
> Failed to git add LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html. at Tools/Scripts/svn-apply line 470.

🤷🏻‍♂️
Comment 3 Antti Koivisto 2019-08-07 07:55:00 PDT
Comment on attachment 375673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review

> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53
> +bool containsOffset(const RenderObject&, const Layout&, unsigned);

This declaration has different signature than the definition below (no OffsetType).

> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122
> +    bool isCaretOffsetType = offsetType == OffsetType::CaretOffset;

This helper bool doesn't seem necessary.
Comment 4 Wenson Hsieh 2019-08-07 07:58:17 PDT
Comment on attachment 375673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review

>> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53
>> +bool containsOffset(const RenderObject&, const Layout&, unsigned);
> 
> This declaration has different signature than the definition below (no OffsetType).

Oops, fixed!

>> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122
>> +    bool isCaretOffsetType = offsetType == OffsetType::CaretOffset;
> 
> This helper bool doesn't seem necessary.

Sounds good! Removed this local variable.
Comment 5 Wenson Hsieh 2019-08-07 08:16:05 PDT
Created attachment 375698 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-08-07 09:23:58 PDT
Comment on attachment 375698 [details]
Patch for landing

Clearing flags on attachment: 375698

Committed r248368: <https://trac.webkit.org/changeset/248368>