<rdar://problem/53501354>
Created attachment 375673 [details] Patch
> perl Tools/Scripts/svn-apply --force .buildbot-diff > in dir C:\Buildbot\WinCairo-EWS\build (timeout 300 secs) > ... > patch: **** Can't create file C:\Users\ContainerAdministrator\AppData\Local\Temp/ppz02368 : File exists > fatal: pathspec 'LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html' did not match any files > Failed to git add LayoutTests/editing/inserting/insert-paragraph-in-designmode-document.html. at Tools/Scripts/svn-apply line 470. 🤷🏻♂️
Comment on attachment 375673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review > Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53 > +bool containsOffset(const RenderObject&, const Layout&, unsigned); This declaration has different signature than the definition below (no OffsetType). > Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122 > + bool isCaretOffsetType = offsetType == OffsetType::CaretOffset; This helper bool doesn't seem necessary.
Comment on attachment 375673 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375673&action=review >> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:53 >> +bool containsOffset(const RenderObject&, const Layout&, unsigned); > > This declaration has different signature than the definition below (no OffsetType). Oops, fixed! >> Source/WebCore/rendering/SimpleLineLayoutFunctions.h:122 >> + bool isCaretOffsetType = offsetType == OffsetType::CaretOffset; > > This helper bool doesn't seem necessary. Sounds good! Removed this local variable.
Created attachment 375698 [details] Patch for landing
Comment on attachment 375698 [details] Patch for landing Clearing flags on attachment: 375698 Committed r248368: <https://trac.webkit.org/changeset/248368>