Bug 200482 – Web Inspector: RTL: Console should be always LTR

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 375658 [details]
[Image] Bug

JavaScript is strictly RTL.

For example, this JS in RTL mode:

    function getElementById() {
        [native code]
    } = $1

becomes this:

    } ()function getElementById
        [native code]
    $1 = {

Which is invalid and hardly even readable.

[Nikita Vasilyev]

Created attachment 375981 [details]
Patch

[Nikita Vasilyev]

Created attachment 375982 [details]
[Image] With patch applied

[Joseph Pecoraro]

Comment on attachment 375981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375981&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js:44
> +        this._element.dir = "ltr";

Why do we put the `dir=ltr` on the ConsoleMessageView / ConsoleCommandView and not just on the LogContentView itself? Are there things in the Console log that we still want to be RTL?

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:73
> +body[dir=rtl] [dir=ltr] .tree-outline .item :matches(.disclosure-button, .icon) {

Nice, I like this approach.

[Nikita Vasilyev]

(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 375981 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375981&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js:44
> > +        this._element.dir = "ltr";
> 
> Why do we put the `dir=ltr` on the ConsoleMessageView / ConsoleCommandView
> and not just on the LogContentView itself? Are there things in the Console
> log that we still want to be RTL?

Yes, "Console cleared at 11:49:23 AM".

[WebKit Commit Bot]

Comment on attachment 375981 [details]
Patch

Clearing flags on attachment: 375981

Committed r248766: <https://trac.webkit.org/changeset/248766>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54382964>