Bug 200481 - Web Inspector: RTL: content of Variables section should always be LTR
Summary: Web Inspector: RTL: content of Variables section should always be LTR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-06 15:42 PDT by Nikita Vasilyev
Modified: 2019-08-07 14:33 PDT (History)
4 users (show)

See Also:

Attachments
[Image] Bug (141.09 KB, image/png)
2019-08-06 15:42 PDT, Nikita Vasilyev 		no flags Details
Patch (1.46 KB, patch)
2019-08-06 15:49 PDT, Nikita Vasilyev 		hi: review+
Details | Formatted Diff | Diff
[Image] With patch applied (134.00 KB, image/png)
2019-08-07 11:19 PDT, Nikita Vasilyev 		no flags Details
Patch (1.62 KB, patch)
2019-08-07 13:55 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2019-08-06 15:42:43 PDT 
Created attachment 375655 [details]
[Image] Bug

Variables section (Elements tab, Computed panel) contains CSS.
CSS is LTR, so this section should be LTR.
Comment 1 Nikita Vasilyev 2019-08-06 15:49:12 PDT 
Created attachment 375657 [details]
Patch
Comment 2 Nikita Vasilyev 2019-08-07 11:19:26 PDT 
Created attachment 375718 [details]
[Image] With patch applied
Comment 3 Devin Rousso 2019-08-07 13:51:28 PDT 
Comment on attachment 375657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375657&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js:124
> +        variablesRow.element.dir = "ltr";

Can we put this on `this._variablesTextEditor.element` instead?  That way, its more "contained" to only what needs to be LTR.
Comment 4 Nikita Vasilyev 2019-08-07 13:55:42 PDT 
Created attachment 375748 [details]
Patch
Comment 5 WebKit Commit Bot 2019-08-07 14:32:53 PDT 
Comment on attachment 375748 [details]
Patch

Clearing flags on attachment: 375748

Committed r248390: <https://trac.webkit.org/changeset/248390>
Comment 6 WebKit Commit Bot 2019-08-07 14:32:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-07 14:33:21 PDT 
<rdar://problem/54051047>