Bug 200477 - Public iOS SDK build is broken after r248071 (_CTFontCreateForCharactersWithLanguageAndOption)
Summary: Public iOS SDK build is broken after r248071 (_CTFontCreateForCharactersWithL...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords:
Depends on:
Blocks: 202263
  Show dependency tree / graph
 
Reported: 2019-08-06 13:38 PDT by Ali Juma
Modified: 2019-09-26 06:43 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2019-08-06 13:40 PDT, Ali Juma 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2019-08-06 13:38:17 PDT 
Public iOS SDK build is broken after r248071
Comment 1 Ali Juma 2019-08-06 13:40:49 PDT 
Created attachment 375648 [details]
Patch
Comment 2 Alexey Proskuryakov 2019-08-06 16:48:37 PDT 
How will we remember to remove this workaround later? This change is pretty risky in that we may end up having different behavior indefinitely.
Comment 3 Alexey Proskuryakov 2019-08-06 16:50:12 PDT 
Also, if iOS build is broken, presumably macOS build is broken too?
Comment 4 Jonathan Bedard 2019-08-06 16:53:17 PDT 
(In reply to Alexey Proskuryakov from comment #3)
> Also, if iOS build is broken, presumably macOS build is broken too?

I believe the Catalina seed is broken too.
Comment 5 Ali Juma 2019-08-07 06:17:32 PDT 
(In reply to Alexey Proskuryakov from comment #2)
> How will we remember to remove this workaround later? This change is pretty
> risky in that we may end up having different behavior indefinitely.

I'm happy to just apply this locally for now and wait to see if the problem resolves itself with a new beta.
Comment 6 Alexey Proskuryakov 2019-08-07 13:08:49 PDT 
Applying the patch locally for now seems best if that works for you.
Comment 7 Frédéric Wang (:fredw) 2019-09-26 05:35:58 PDT 
@Ali: Do you still have this issue with the latest XCode release?
Comment 8 Frédéric Wang (:fredw) 2019-09-26 05:36:50 PDT 
(In reply to Frédéric Wang (:fredw) from comment #7)
> @Ali: Do you still have this issue with the latest XCode release?

(I'm able to build WebKit with the workaround from 202264)
Comment 9 Ali Juma 2019-09-26 06:43:37 PDT 
I'm able to build now. I haven't run into the problems from bug 202264 either.