Bug 200476 - Enable XCBuild for `make` builds
Summary: Enable XCBuild for `make` builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-06 12:51 PDT by Keith Rollin
Modified: 2019-08-06 14:58 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2019-08-06 12:54 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2019-08-06 12:57 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2019-08-06 12:51:36 PDT 
All projects have now been tested under XCBuild and successfully build. Enable the use of XCBuild when performing builds with `make` and when using a sufficient version of Xcode. We set this version to Xcode 11 since Xcode 10 -- even though it supports XCBuild -- does not support a build facility needed to build WebKit (Bug 197072, Bug 197116, Bug 197340).

Do not enable XCBuild in the Xcode projects themselves since these projects may need to be used under older versions of Xcode and there's no way to make those project changes sensitive to the version of Xcode being used. This means that builds performed in the Xcode IDE will not use XCBuild.

<rdar://problem/50771065>
Comment 1 Keith Rollin 2019-08-06 12:54:22 PDT 
Created attachment 375644 [details]
Patch
Comment 2 Keith Rollin 2019-08-06 12:56:19 PDT 
This change also supports XCBuild with build-webkit. I'll update the patch to note that.
Comment 3 Keith Rollin 2019-08-06 12:57:29 PDT 
Created attachment 375645 [details]
Patch
Comment 4 Jonathan Bedard 2019-08-06 13:00:01 PDT 
(In reply to Keith Rollin from comment #0)
> All projects have now been tested under XCBuild and successfully build.
> Enable the use of XCBuild when performing builds with `make` and when using
> a sufficient version of Xcode. We set this version to Xcode 11 since Xcode
> 10 -- even though it supports XCBuild -- does not support a build facility
> needed to build WebKit (Bug 197072, Bug 197116, Bug 197340).
> 
> Do not enable XCBuild in the Xcode projects themselves since these projects
> may need to be used under older versions of Xcode and there's no way to make
> those project changes sensitive to the version of Xcode being used. This
> means that builds performed in the Xcode IDE will not use XCBuild.
> 
> <rdar://problem/50771065>

Which versions of Xcode don't have XCBuild, at this point?
Comment 5 Keith Rollin 2019-08-06 13:06:54 PDT 
Xcode 8 does not support XCBuild. Xcode 9 supports XCBuild, but there were some bugs. Xcode 10 supports XCBuild, but doesn't have the new feature we require.
Comment 6 WebKit Commit Bot 2019-08-06 14:57:59 PDT 
Comment on attachment 375645 [details]
Patch

Clearing flags on attachment: 375645

Committed r248317: <https://trac.webkit.org/changeset/248317>
Comment 7 WebKit Commit Bot 2019-08-06 14:58:00 PDT 
All reviewed patches have been landed.  Closing bug.