RESOLVED FIXED 200473
[LFC] Introduce Layout::Phase class 
https://bugs.webkit.org/show_bug.cgi?id=200473
Summary [LFC] Introduce Layout::Phase class
alan
Reported 2019-08-06 11:38:24 PDT
to be able to check whether we could carry out certain actions.
Attachments
Patch (13.89 KB, patch)
2019-08-06 11:42 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.04 KB, patch)
2019-08-06 21:16 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-06 11:38:45 PDT
<rdar://problem/53996061>
alan
Comment 2 2019-08-06 11:42:27 PDT
Created attachment 375635 [details] Patch
alan
Comment 3 2019-08-06 21:16:11 PDT
Created attachment 375682 [details] Patch
WebKit Commit Bot
Comment 4 2019-08-07 07:24:00 PDT
Comment on attachment 375682 [details] Patch Clearing flags on attachment: 375682 Committed r248364: <https://trac.webkit.org/changeset/248364>
WebKit Commit Bot
Comment 5 2019-08-07 07:24:01 PDT
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 6 2019-08-07 14:27:30 PDT
Comment on attachment 375682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375682&action=review > Source/WebCore/layout/LayoutPhase.cpp:37 > + static NeverDestroyed<Phase> phase; > + return phase; Global state like this is going to make any threading work "challenging." Are you sure you want to do this?
alan
Comment 7 2019-08-07 19:54:30 PDT
(In reply to Sam Weinig from comment #6) > Comment on attachment 375682 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=375682&action=review > > > Source/WebCore/layout/LayoutPhase.cpp:37 > > + static NeverDestroyed<Phase> phase; > > + return phase; > > Global state like this is going to make any threading work "challenging." > Are you sure you want to do this? You are right. I need to re-work this at some point.
alan
Comment 8 2019-08-08 08:52:25 PDT
(In reply to zalan from comment #7) > (In reply to Sam Weinig from comment #6) > > Comment on attachment 375682 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=375682&action=review > > > > > Source/WebCore/layout/LayoutPhase.cpp:37 > > > + static NeverDestroyed<Phase> phase; > > > + return phase; > > > > Global state like this is going to make any threading work "challenging." > > Are you sure you want to do this? > You are right. I need to re-work this at some point. Guess I need to turn it into formatting context based. Independent (sibling, out-of-flow etc) formatting contexts could be mutated and laid out simultaneously.
Note You need to log in before you can comment on or make changes to this bug.