Bug 200471 - [WHLSL] Metal code generation unnecessarily does string copies by passing partial results as Strings
Summary: [WHLSL] Metal code generation unnecessarily does string copies by passing par...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-06 10:37 PDT by Sam Weinig
Modified: 2022-02-28 03:30 PST (History)
7 users (show)

See Also:

Attachments
Patch (68.74 KB, patch)
2019-08-06 10:47 PDT, Sam Weinig 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2019-08-06 10:37:42 PDT 
WHLSL Metal code generation unnecessarily does string copies by passing partial results as Strings
Comment 1 Sam Weinig 2019-08-06 10:47:42 PDT 
Created attachment 375632 [details]
Patch
Comment 2 Saam Barati 2019-08-06 10:58:57 PDT 
Comment on attachment 375632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375632&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:93
> +        // FIXME: Add direct StringBuilder -> NSString conversion to void extra copy into a WTF::String

void => avoid

Maybe also worth filing a bug?

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:405
> +        // FIXME: Add direct StringBuilder -> NSString conversion to void extra copy into a WTF::String

ditto
Comment 3 Sam Weinig 2019-08-06 11:47:00 PDT 
(In reply to Saam Barati from comment #2)
> Comment on attachment 375632 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375632&action=review
> 
> > Source/WebCore/platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:93
> > +        // FIXME: Add direct StringBuilder -> NSString conversion to void extra copy into a WTF::String
> 
> void => avoid
> 
> Maybe also worth filing a bug?

https://bugs.webkit.org/show_bug.cgi?id=200474
Comment 4 Sam Weinig 2019-08-06 12:04:02 PDT 
Committed r248307: <https://trac.webkit.org/changeset/248307>
Comment 5 Radar WebKit Bug Importer 2019-08-06 12:04:20 PDT 
<rdar://problem/53997291>