Bug 200467 - Add release assert against InvalidationRuleSet mutation during invalidation
Summary: Add release assert against InvalidationRuleSet mutation during invalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-06 05:18 PDT by Antti Koivisto
Modified: 2019-08-06 09:19 PDT (History)
3 users (show)

See Also:

Attachments
patch (4.55 KB, patch)
2019-08-06 05:26 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-08-06 05:18:33 PDT 
There have been some rare nullptr crashes here.
Comment 1 Antti Koivisto 2019-08-06 05:26:25 PDT 
Created attachment 375619 [details]
patch
Comment 2 Chris Dumez 2019-08-06 08:11:52 PDT 
Comment on attachment 375619 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375619&action=review

> Source/WebCore/css/DocumentRuleSets.h:79
> +    static bool s_isInvalidatingStyleWithRuleSets;

I am unclear why it is OK for this to be a static. I do not think DocumentRuleSets are process-global, are they?
Comment 3 Antti Koivisto 2019-08-06 08:22:22 PDT 
> I am unclear why it is OK for this to be a static. I do not think
> DocumentRuleSets are process-global, are they?

Invalidation affecting some other random DocumentRuleSets would be equally bad, this covers that case too.
Comment 4 Chris Dumez 2019-08-06 08:27:49 PDT 
Comment on attachment 375619 [details]
patch

Ok then.
Comment 5 WebKit Commit Bot 2019-08-06 09:18:11 PDT 
Comment on attachment 375619 [details]
patch

Clearing flags on attachment: 375619

Committed r248297: <https://trac.webkit.org/changeset/248297>
Comment 6 WebKit Commit Bot 2019-08-06 09:18:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-06 09:19:24 PDT 
<rdar://problem/53988679>