Bug 200466 – REGRESSION: Cannot tap on any buttons on m.naver.com home screen on iPad

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antti Koivisto]

The page calls preventDefault() for a mouse event generated by site specific quirk.

[Antti Koivisto]

<rdar://problem/52571754>

[Antti Koivisto]

Created attachment 375616 [details]
patch

[WebKit Commit Bot]

Comment on attachment 375616 [details]
patch

Clearing flags on attachment: 375616

Committed r248295: <https://trac.webkit.org/changeset/248295>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[zalan]

Comment on attachment 375616 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375616&action=review

> Source/WebCore/page/Quirks.cpp:303
> +        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.

SimulatedMouseEventsDispatchPolicy should definitely be Deny on mobile pages for example when the user explicitly asks for the mobile version.

[Geoffrey Garen]

Comment on attachment 375616 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375616&action=review

>> Source/WebCore/page/Quirks.cpp:303
>> +        // FIXME: Maybe this quirk should be disabled for "m." subdomains on all sites? These are generally mobile sites that don't need mouse events.
> 
> SimulatedMouseEventsDispatchPolicy should definitely be Deny on mobile pages for example when the user explicitly asks for the mobile version.

My understanding is that we only set WebsiteSimulatedMouseEventsDispatchPolicy::Allow when in desktop mode. (See WebPageProxy::effectiveContentModeAfterAdjustingPolicies.) I wonder how we ended up in desktop mode at all on an m. site.

[Antti Koivisto]

If you go to m.naver.com (or any URL) on iPad it will be loaded by default in desktop mode. Or do we have heuristics somewhere that should figure out it is a mobile site?

[Antti Koivisto]

If you go to the top naver.com you get redirected to the m. subdomain only in mobile mode. However there is no automatic redirect back to the main site in desktop mode. If you for example have an existing bookmark it will probably point to the m. site.

[Geoffrey Garen]

(In reply to Antti Koivisto from comment #7)
> If you go to m.naver.com (or any URL) on iPad it will be loaded by default
> in desktop mode. Or do we have heuristics somewhere that should figure out
> it is a mobile site?

Always desktop mode, modulo a short list of exceptions.

[Geoffrey Garen]

(In reply to Antti Koivisto from comment #8)
> If you go to the top naver.com you get redirected to the m. subdomain only
> in mobile mode. However there is no automatic redirect back to the main site
> in desktop mode. If you for example have an existing bookmark it will
> probably point to the m. site.

Makes sense.