WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
200461
[WHLSL] We should generate identical metal code for the same WHLSL program
https://bugs.webkit.org/show_bug.cgi?id=200461
Summary
[WHLSL] We should generate identical metal code for the same WHLSL program
Saam Barati
Reported
2019-08-05 18:08:25 PDT
Metal process caches shaders (with what appears to be text equality). Therefore, we should always generate the same Metal program for the same WHLSL shader. Currently, we don't do this for a few reasons, often because we rely on pointer hash tables and their iteration order. E.g, I know of at least: - We emit struct fields in different order - I think we do the same for enum - I think we might do the same for functions
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2019-08-07 13:22:11 PDT
It would be good to be able to dump the metal shaders in layout tests (much like we dump the render tree) for testing.
Myles C. Maxfield
Comment 2
2020-05-05 00:42:37 PDT
WHLSL is no longer relevant.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug