Bug 200449 – Web Inspector: RTL: go-to arrows and expand triangles in Computed panel should match their context

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 375566 [details]
[Image] Bug

Properties section of the Computed panel is strictly LTR but disclosure triangles and go-to arrows are flipped.
They shouldn't be!

[Nikita Vasilyev]

Created attachment 375567 [details]
Patch

[Nikita Vasilyev]

Created attachment 375569 [details]
[Image] With patch applied

[Nikita Vasilyev]

I think Brian would be a good reviwer for this.

[Joseph Pecoraro]

Comment on attachment 375567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375567&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Main.css:289
> -body[dir=rtl] .go-to-arrow {
> +[dir=rtl] .go-to-arrow {

Will we need to worry about these?

    Views/DataGrid.css
    343:body[dir=ltr] .data-grid td .go-to-arrow {
    347:body[dir=rtl] .data-grid td .go-to-arrow {

I suspect this would affect positioning in Timeline Views, but I guess we won't be overriding it again in any of those data grids.

[Joseph Pecoraro]

Comment on attachment 375567 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375567&action=review

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css:-69
> -body[dir=rtl] .computed-style-section .computed-property-item .disclosure-button {
> -    transform: scaleX(-1);
> -}

What about the headers of sidebar sections. Like 'Properties'. Won't that disclosure triangle, if closed, want to be transformed?

[Nikita Vasilyev]

(In reply to Joseph Pecoraro from comment #4)
> Comment on attachment 375567 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375567&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Views/Main.css:289
> > -body[dir=rtl] .go-to-arrow {
> > +[dir=rtl] .go-to-arrow {
> 
> Will we need to worry about these?
> 
>     Views/DataGrid.css
>     343:body[dir=ltr] .data-grid td .go-to-arrow {
>     347:body[dir=rtl] .data-grid td .go-to-arrow {
> 
> I suspect this would affect positioning in Timeline Views, but I guess we
> won't be overriding it again in any of those data grids.

It's unlikely we'd need to worry about these.

[Nikita Vasilyev]

Created attachment 375634 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375634 [details]
Patch

Clearing flags on attachment: 375634

Committed r248311: <https://trac.webkit.org/changeset/248311>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54001140>