Mangled WHLSL names don't need to allocate Strings
Created attachment 375507 [details] Patch
Created attachment 375508 [details] Patch
Comment on attachment 375508 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375508&action=review r=me Just curious: Did you measure any compile time speedup? I like to flip the “dumpPhaseTimes” Boolean to true in WHLSLPrepare and run some shaders to measure compile time changes. I’ll email you the web page I use. > Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:159 > + return string.is8Bit(); Why not an assert?
Comment on attachment 375508 [details] Patch Clearing flags on attachment: 375508 Committed r248266: <https://trac.webkit.org/changeset/248266>
All reviewed patches have been landed. Closing bug.
<rdar://problem/53927415>
Thanks for the bug and the appropriate fix. Webroot Geek Squad provides the users of Secureanywhere with the best technical support and assistance for their queries and problems after they Install Webroot from: https://secureanywherewebroot.com/