Bug 200429 - Mangled WHLSL names don't need to allocate Strings
Summary: Mangled WHLSL names don't need to allocate Strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-04 13:14 PDT by Sam Weinig
Modified: 2019-08-04 22:55 PDT (History)
8 users (show)

See Also:


Attachments
Patch (73.77 KB, patch)
2019-08-04 13:23 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (74.13 KB, patch)
2019-08-04 13:49 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2019-08-04 13:14:58 PDT
Mangled WHLSL names don't need to allocate Strings
Comment 1 Sam Weinig 2019-08-04 13:23:01 PDT
Created attachment 375507 [details]
Patch
Comment 2 Sam Weinig 2019-08-04 13:49:07 PDT
Created attachment 375508 [details]
Patch
Comment 3 Saam Barati 2019-08-04 18:15:36 PDT
Comment on attachment 375508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375508&action=review

r=me

Just curious: Did you measure any compile time speedup? I like to flip the “dumpPhaseTimes” Boolean to true in WHLSLPrepare and run some shaders to measure compile time changes. I’ll email you the web page I use.

> Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:159
> +                return string.is8Bit();

Why not an assert?
Comment 4 WebKit Commit Bot 2019-08-04 20:26:40 PDT
Comment on attachment 375508 [details]
Patch

Clearing flags on attachment: 375508

Committed r248266: <https://trac.webkit.org/changeset/248266>
Comment 5 WebKit Commit Bot 2019-08-04 20:26:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-08-04 20:27:17 PDT
<rdar://problem/53927415>
Comment 7 Mike Ronin 2019-08-04 22:55:02 PDT
Thanks for the bug and the appropriate fix.
Webroot Geek Squad provides the users of Secureanywhere with the best technical support and assistance for their queries and problems after they Install Webroot from: https://secureanywherewebroot.com/