RESOLVED FIXED 200426
[LFC] Cleanup preferred width computation 
https://bugs.webkit.org/show_bug.cgi?id=200426
Summary [LFC] Cleanup preferred width computation
zalan
Reported 2019-08-04 00:59:33 PDT
it needs some cleanup.
Attachments
Patch (33.71 KB, patch)
2019-08-04 02:09 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-04 00:59:56 PDT
<rdar://problem/53912607>
zalan
Comment 2 2019-08-04 02:09:50 PDT
Created attachment 375504 [details] Patch
Antti Koivisto
Comment 3 2019-08-04 02:42:16 PDT
Comment on attachment 375504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375504&action=review > Source/WebCore/ChangeLog:45 > + In LFC, we start with the following layout tree > + <container> -> block formatting context > + <container> -> inline formatting context > + <anonymous inline box> > + <container> -> inline formatting context > + <anonymous inline box> > + <container> -> inline formatting context > + and when the style change happens, we don't need to tear down the tree at all. Not only that, but since every formatting contexts stay the same > + we can just reuse their states and actually skip all the steps (even the positioning since the absolutely positioned container has static top/bottom/left/right). > + > + Surprisingly the final layout produces the exact same "display boxes" as the original layout. Nice!
WebKit Commit Bot
Comment 4 2019-08-04 03:16:12 PDT
Comment on attachment 375504 [details] Patch Clearing flags on attachment: 375504 Committed r248262: <https://trac.webkit.org/changeset/248262>
WebKit Commit Bot
Comment 5 2019-08-04 03:16:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.