Bug 200426 - [LFC] Cleanup preferred width computation
Summary: [LFC] Cleanup preferred width computation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-04 00:59 PDT by zalan
Modified: 2019-08-04 03:16 PDT (History)
6 users (show)

See Also:


Attachments
Patch (33.71 KB, patch)
2019-08-04 02:09 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-08-04 00:59:33 PDT
it needs some cleanup.
Comment 1 Radar WebKit Bug Importer 2019-08-04 00:59:56 PDT
<rdar://problem/53912607>
Comment 2 zalan 2019-08-04 02:09:50 PDT
Created attachment 375504 [details]
Patch
Comment 3 Antti Koivisto 2019-08-04 02:42:16 PDT
Comment on attachment 375504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375504&action=review

> Source/WebCore/ChangeLog:45
> +        In LFC, we start with the following layout tree
> +        <container> -> block formatting context
> +          <container> -> inline formatting context
> +            <anonymous inline box>
> +          <container> -> inline formatting context
> +            <anonymous inline box>
> +          <container> -> inline formatting context
> +        and when the style change happens, we don't need to tear down the tree at all. Not only that, but since every formatting contexts stay the same
> +        we can just reuse their states and actually skip all the steps (even the positioning since the absolutely positioned container has static top/bottom/left/right).
> +
> +        Surprisingly the final layout produces the exact same "display boxes" as the original layout.

Nice!
Comment 4 WebKit Commit Bot 2019-08-04 03:16:12 PDT
Comment on attachment 375504 [details]
Patch

Clearing flags on attachment: 375504

Committed r248262: <https://trac.webkit.org/changeset/248262>
Comment 5 WebKit Commit Bot 2019-08-04 03:16:14 PDT
All reviewed patches have been landed.  Closing bug.