Bug 200411 - Address comments on r248178
Summary: Address comments on r248178
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-02 17:04 PDT by Keith Miller
Modified: 2019-08-02 21:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2019-08-02 17:04 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (3.65 KB, patch)
2019-08-02 17:38 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (3.65 KB, patch)
2019-08-02 18:25 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-08-02 17:04:10 PDT 
Address comments on r248178
Comment 1 Keith Miller 2019-08-02 17:04:40 PDT 
Created attachment 375468 [details]
Patch
Comment 2 Saam Barati 2019-08-02 17:05:56 PDT 
Comment on attachment 375468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375468&action=review

> Source/JavaScriptCore/b3/B3Opcode.h:300
> +    // It's assumumed that each entry in a tuple has a fixed Numeric B3 Type (i.e. not Void or Tuple).

can we validate?
Comment 3 Keith Miller 2019-08-02 17:38:53 PDT 
Created attachment 375471 [details]
Patch
Comment 4 Keith Miller 2019-08-02 18:25:52 PDT 
Created attachment 375473 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-08-02 21:01:41 PDT 
Comment on attachment 375473 [details]
Patch for landing

Clearing flags on attachment: 375473

Committed r248195: <https://trac.webkit.org/changeset/248195>
Comment 6 WebKit Commit Bot 2019-08-02 21:01:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-08-02 21:02:18 PDT 
<rdar://problem/53891665>