Bug 200404 – run-webkit-tests asserts when the iPhone XR simulator is running

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

run-webkit-tests asserts when the iPhone XR simulator is running

[Radar WebKit Bug Importer]

<rdar://problem/53878739>

[Dean Jackson]

UnicodeEncodeError raised: 'ascii' codec can't encode character u'\u0280' in position 1: ordinal not in range(128)
Traceback (most recent call last):
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main
    run_details = run(port, options, args, stderr)
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 452, in run
    run_details = manager.run(args)
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 187, in run
    for_device_type = 'for {} '.format(device_type) if device_type else ''
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/xcode/device_type.py", line 120, in __str__
    hardware_type=' {}'.format(self.hardware_type) if self.hardware_type else '',
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0280' in position 1: ordinal not in range(128)

[Radar WebKit Bug Importer]

<rdar://problem/53878791>

[Dean Jackson]

Created attachment 375453 [details]
Patch

[Jonathan Bedard]

This change is correct, but probably not sufficient.

Bet if we edited the output of Tools/Scripts/webkitpy/Xcode/simulated_device_unittest.py, we could get a complete fix.

[Jonathan Bedard]

Comment on attachment 375453 [details]
Patch

Hold up...this breaks things for me locally in a surprising way....investigating.

[Jonathan Bedard]

Created attachment 375462 [details]
Patch

[Jonathan Bedard]

Comment on attachment 375462 [details]
Patch

Talked to Russell, this fixed XR's for him. I think this is all we need, so I'm going to land it.

I'll be keeping an eye out for this sort of thing, though, we do a bad job at handling unicode in webkitpy.

[WebKit Commit Bot]

Comment on attachment 375462 [details]
Patch

Clearing flags on attachment: 375462

Committed r248270: <https://trac.webkit.org/changeset/248270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.