Bug 200404 - run-webkit-tests asserts when the iPhone XR simulator is running
Summary: run-webkit-tests asserts when the iPhone XR simulator is running
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-02 14:05 PDT by Dean Jackson
Modified: 2019-08-05 09:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2019-08-02 14:10 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (24.17 KB, patch)
2019-08-02 15:41 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-08-02 14:05:42 PDT 
run-webkit-tests asserts when the iPhone XR simulator is running
Comment 1 Radar WebKit Bug Importer 2019-08-02 14:06:18 PDT 
<rdar://problem/53878739>
Comment 2 Dean Jackson 2019-08-02 14:07:14 PDT 
UnicodeEncodeError raised: 'ascii' codec can't encode character u'\u0280' in position 1: ordinal not in range(128)
Traceback (most recent call last):
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 91, in main
    run_details = run(port, options, args, stderr)
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 452, in run
    run_details = manager.run(args)
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 187, in run
    for_device_type = 'for {} '.format(device_type) if device_type else ''
  File "/Users/dino/apple/code/OpenSource/Tools/Scripts/webkitpy/xcode/device_type.py", line 120, in __str__
    hardware_type=' {}'.format(self.hardware_type) if self.hardware_type else '',
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0280' in position 1: ordinal not in range(128)
Comment 3 Radar WebKit Bug Importer 2019-08-02 14:07:27 PDT 
<rdar://problem/53878791>
Comment 4 Dean Jackson 2019-08-02 14:10:09 PDT 
Created attachment 375453 [details]
Patch
Comment 5 Jonathan Bedard 2019-08-02 14:15:06 PDT 
This change is correct, but probably not sufficient.

Bet if we edited the output of Tools/Scripts/webkitpy/Xcode/simulated_device_unittest.py, we could get a complete fix.
Comment 6 Jonathan Bedard 2019-08-02 14:34:20 PDT 
Comment on attachment 375453 [details]
Patch

Hold up...this breaks things for me locally in a surprising way....investigating.
Comment 7 Jonathan Bedard 2019-08-02 15:41:21 PDT 
Created attachment 375462 [details]
Patch
Comment 8 Jonathan Bedard 2019-08-05 09:12:03 PDT 
Comment on attachment 375462 [details]
Patch

Talked to Russell, this fixed XR's for him. I think this is all we need, so I'm going to land it.

I'll be keeping an eye out for this sort of thing, though, we do a bad job at handling unicode in webkitpy.
Comment 9 WebKit Commit Bot 2019-08-05 09:42:30 PDT 
Comment on attachment 375462 [details]
Patch

Clearing flags on attachment: 375462

Committed r248270: <https://trac.webkit.org/changeset/248270>
Comment 10 WebKit Commit Bot 2019-08-05 09:42:32 PDT 
All reviewed patches have been landed.  Closing bug.