RESOLVED FIXED 200379
Remove constructors and operators of FontPlatformData defined only for Freetype 
https://bugs.webkit.org/show_bug.cgi?id=200379
Summary Remove constructors and operators of FontPlatformData defined only for Freetype
Konstantin Tokarev
Reported 2019-08-01 20:40:20 PDT
These methods only make maintenance harder, as all data fields are trivially copyable. Constructors generated by compiler should be used instead.
Attachments
Patch (3.21 KB, patch)
2019-08-01 20:41 PDT, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2019-08-01 20:41:43 PDT
Created attachment 375388 [details] Patch
Carlos Garcia Campos
Comment 2 2019-08-02 01:34:49 PDT
Comment on attachment 375388 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=375388&action=review > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:-155 > - I think we only needed this when we had m_fallbacks and m_harfBuzzFace members that we had to reset on copy.
WebKit Commit Bot
Comment 3 2019-08-02 03:20:54 PDT
Comment on attachment 375388 [details] Patch Clearing flags on attachment: 375388 Committed r248152: <https://trac.webkit.org/changeset/248152>
WebKit Commit Bot
Comment 4 2019-08-02 03:20:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-08-02 03:21:17 PDT
<rdar://problem/53856484>
Note You need to log in before you can comment on or make changes to this bug.