Bug 200379 - Remove constructors and operators of FontPlatformData defined only for Freetype
Summary: Remove constructors and operators of FontPlatformData defined only for Freetype
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-08-01 20:40 PDT by Konstantin Tokarev
Modified: 2019-08-02 03:21 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2019-08-01 20:41 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2019-08-01 20:40:20 PDT 
These methods only make maintenance harder, as all data fields are trivially copyable. Constructors generated by compiler should be used instead.
Comment 1 Konstantin Tokarev 2019-08-01 20:41:43 PDT 
Created attachment 375388 [details]
Patch
Comment 2 Carlos Garcia Campos 2019-08-02 01:34:49 PDT 
Comment on attachment 375388 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375388&action=review

> Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:-155
> -

I think we only needed this when we had m_fallbacks and m_harfBuzzFace members that we had to reset on copy.
Comment 3 WebKit Commit Bot 2019-08-02 03:20:54 PDT 
Comment on attachment 375388 [details]
Patch

Clearing flags on attachment: 375388

Committed r248152: <https://trac.webkit.org/changeset/248152>
Comment 4 WebKit Commit Bot 2019-08-02 03:20:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-08-02 03:21:17 PDT 
<rdar://problem/53856484>