Bug 200364 – Web Inspector: "Inspector.initialized" happens before breakpoints are set

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

"Inspector.initialized" happens before breakpoints are set

This probably means `auto-attach` will not have breakpoints set up appropriately and would miss breakpoints.

Notes:
• Inspector page loading protocol log:

    ...
    [Log] Trace: request (page-338) – {id: 62, method: "Inspector.initialized"}
    ...
    [Log] Trace: request (page-338) – {id: 72, method: "Debugger.setBreakpointByUrl", params: Object}
    [Log] Trace: request (page-338) – {id: 74, method: "Debugger.setBreakpointByUrl", params: Object}
    ...

[Devin Rousso]

Created attachment 375370 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 375370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375370&action=review

> Source/WebInspectorUI/UserInterface/Protocol/Target.js:89
> +        Promise.all(Target._initializationPromises).then(() => {

Would we want to assert here that `Target._initializationPromises` is not empty? We always expect at least one (Breakpoints)

This assert would let us know if we change something and went too early.

> Source/WebInspectorUI/UserInterface/Protocol/Target.js:145
> +        promise.then(() => {
> +            Target._initializationPromises.remove(promise);
> +        });

Oh, you're removing promises from the list... probably to reduce memory.

Maybe we should leave them for the assert, which seems pretty valuable. Or have an assertion:

    console.assert((Target._initializationPromises.length > 0) || (Target._completedInitializationPromises > 0));

And have this increment `Target._completedInitializationPromises` as well as remove the promise.

That keeps removing the promises at the cost of a counter for a useful assertion.

[Devin Rousso]

Created attachment 375443 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375443 [details]
Patch

Clearing flags on attachment: 375443

Committed r248176: <https://trac.webkit.org/changeset/248176>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53876805>