results.webkit.org: Force update cache when timeline updated

[Jonathan Bedard]

We need to force the cache to update when the timeline is updated, and we need an exporter to update the timeline.

[Jonathan Bedard]

Created attachment 375349 [details]
Patch

[Zhifei Fang]

Comment on attachment 375349 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375349&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:151
> +        if (element.logicWidth != width || force) {

I think if (force) will be enough here

[Zhifei Fang]

I will give a new patch about this change, we shouldn't force to redraw cache every time when the state change, this will impact the performance.

[Zhifei Fang]

Created attachment 375354 [details]
Patch

[Jonathan Bedard]

Comment on attachment 375354 [details]
Patch

Can we add the exporter hook?

Also, I'm going to mark my patch as obsolete, since I redrew on scroll too.

[Zhifei Fang]

Created attachment 375357 [details]
Patch

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #5)
> Comment on attachment 375354 [details]
> Patch
> 
> Can we add the exporter hook?
> 
> Also, I'm going to mark my patch as obsolete, since I redrew on scroll too.

Added.

[Zhifei Fang]

Created attachment 375366 [details]
Patch

[Jonathan Bedard]

Comment on attachment 375366 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375366&action=review

> Tools/ChangeLog:11
> +        (Timeline.CanvasXAxisComponent): Force redraw when scales are updated.

I think you also need to mention the fact that you added the exporter bit.

[Zhifei Fang]

Created attachment 375376 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 375376 [details]
Patch

Clearing flags on attachment: 375376

Committed r248146: <https://trac.webkit.org/changeset/248146>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/53846931>