WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
20036
wxWebKit wxPy binary packager for Win
https://bugs.webkit.org/show_bug.cgi?id=20036
Summary
wxWebKit wxPy binary packager for Win
Kevin Ollivier
Reported
2008-07-14 18:06:57 PDT
We'd like to start providing at least periodic binaries, and eventually nightlies, for wxPython developers to be able to try out wxWebKit easily. This patch is a start on that process.
Attachments
patch to build a Win installer for wxWebKit binaries
(7.18 KB, patch)
2008-07-14 18:07 PDT
,
Kevin Ollivier
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kevin Ollivier
Comment 1
2008-07-14 18:07:55 PDT
Created
attachment 22276
[details]
patch to build a Win installer for wxWebKit binaries
Eric Seidel (no email)
Comment 2
2008-08-02 01:17:05 PDT
Comment on
attachment 22276
[details]
patch to build a Win installer for wxWebKit binaries I think the license for the App would actually be a BSD or LGPL license judging by the code in WebKit. retval = os.path.abspath(os.path.join(__file__,"..","..", "..", "WebKitBuild")) WebKit style says there should be a space after each , Your svnrevision lookup should ideally be a function call so that it's easier to add Git-svn support later. Many WebKit hackers use git-svn these days. Otherwise this looks fine. Since you're a committer, I trust you can fix these all w/o needing to upload another patch. Thanks!
Kevin Ollivier
Comment 3
2008-08-02 15:25:24 PDT
landed in
r35528
with changes made, thanks! Also
r35529
contains licensing correction, which I forgot to fix before commit.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug