Bug 200357 – fast/forms/ios/file-upload-panel.html is flaky on iOS 13

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

fast/forms/ios/file-upload-panel.html is flaky on iOS 13.

[Chris Dumez]

<rdar://problem/53028551>

[Chris Dumez]

Created attachment 375340 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 375340 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375340&action=review

> LayoutTests/fast/forms/ios/file-upload-panel.html:54
> -        UIHelper.activateElement(testInput).then(() => {
> +        internals.withUserGesture(() => {

Can we fix UIHelper to do the right thing (or add a new function to it)? UIHelper is the future.

[Chris Dumez]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 375340 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=375340&action=review
> 
> > LayoutTests/fast/forms/ios/file-upload-panel.html:54
> > -        UIHelper.activateElement(testInput).then(() => {
> > +        internals.withUserGesture(() => {
> 
> Can we fix UIHelper to do the right thing (or add a new function to it)?
> UIHelper is the future.

But I have no idea why the tap is getting swallowed (and why this regressed very recently). If I sleep 1 second between taps, then they are no longer swallowed but this is not a viable fix. UIHelper may be the future but HTMLElement.click() is never going away :)

[Chris Dumez]

(In reply to Chris Dumez from comment #4)
> (In reply to Simon Fraser (smfr) from comment #3)
> > Comment on attachment 375340 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=375340&action=review
> > 
> > > LayoutTests/fast/forms/ios/file-upload-panel.html:54
> > > -        UIHelper.activateElement(testInput).then(() => {
> > > +        internals.withUserGesture(() => {
> > 
> > Can we fix UIHelper to do the right thing (or add a new function to it)?
> > UIHelper is the future.
> 
> But I have no idea why the tap is getting swallowed (and why this regressed
> very recently). If I sleep 1 second between taps, then they are no longer
> swallowed but this is not a viable fix. UIHelper may be the future but
> HTMLElement.click() is never going away :)

Note that we already swizzle out all the popover presenting API, however, this is still insufficient. I suspect some kind of UIButton animation when tapping it?

[Andy Estes]

(In reply to Chris Dumez from comment #4)
> But I have no idea why the tap is getting swallowed (and why this regressed
> very recently).

Could it be due to r247866?

Payment Request tests were failing in a very similar way and Zalan resolved it by migrating those tests to using UIHelper.activateElementAtHumanSpeed. Would that work here too?

[Chris Dumez]

Created attachment 375387 [details]
Patch

[Chris Dumez]

(In reply to Andy Estes from comment #6)
> (In reply to Chris Dumez from comment #4)
> > But I have no idea why the tap is getting swallowed (and why this regressed
> > very recently).
> 
> Could it be due to r247866?
> 
> Payment Request tests were failing in a very similar way and Zalan resolved
> it by migrating those tests to using UIHelper.activateElementAtHumanSpeed.
> Would that work here too?

It does. Slow though.

[zalan]

(In reply to Chris Dumez from comment #8)
> (In reply to Andy Estes from comment #6)
> > (In reply to Chris Dumez from comment #4)
> > > But I have no idea why the tap is getting swallowed (and why this regressed
> > > very recently).
> > 
> > Could it be due to r247866?
> > 
> > Payment Request tests were failing in a very similar way and Zalan resolved
> > it by migrating those tests to using UIHelper.activateElementAtHumanSpeed.
> > Would that work here too?
> 
> It does. Slow though.
Human speed.

[Chris Dumez]

Comment on attachment 375387 [details]
Patch

Clearing flags on attachment: 375387

Committed r248145: <https://trac.webkit.org/changeset/248145>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.